Skip to content

Update GivenMatch to SummonFrom #10434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Nov 21, 2020

We should have dropped it but summonFrom still leaks as a language feature.

@nicolasstucki nicolasstucki force-pushed the remove-given-match-from-reflection branch from 8e54f11 to 197cc82 Compare November 21, 2020 15:56
@nicolasstucki nicolasstucki changed the title Remove GivenMatch from reflection API Update GivenMatch to SummonFrom Nov 21, 2020
@nicolasstucki nicolasstucki self-assigned this Nov 21, 2020
@nicolasstucki nicolasstucki marked this pull request as ready for review November 21, 2020 17:58
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit b2c7905 into scala:master Nov 21, 2020
@nicolasstucki nicolasstucki deleted the remove-given-match-from-reflection branch November 21, 2020 21:43
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants