Better expected type for arguments of overloaded methods #10327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pretypeArgs` allows arguments of overloaded methods to be typed with a more precise expected type when the formal parameter types of each overload are all compatible function types, but previously this logic only kicked in for arguments which were syntactically known to be functions themselves, which means that it worked when the argument was `foo(_)` or `x => foo(x)`, but not when it was just `foo`. This commit simply removes this restriction. Fixes scala#10325.
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/10327/ to see the changes. Benchmarks is based on merging with master (3c04f9b) |
odersky
approved these changes
Nov 17, 2020
odersky
force-pushed
the
more-pretyping
branch
from
de209a9 to
5e6bfa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pretypeArgsallows arguments of overloaded methods to be typed with amore precise expected type when the formal parameter types of each overload
are all compatible function types, but previously this logic only kicked
in for arguments which were syntactically known to be functions
themselves, which means that it worked when the argument was
foo(_)orx => foo(x), but not when it was justfoo. This commit simplyremoves this restriction.
Fixes #10325.