-
Notifications
You must be signed in to change notification settings - Fork 1.1k
improved readability of help messages #10304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
b8f9bdb
improved readability of help messages
michelou 5c29cfb
Merge remote-tracking branch 'upstream/master' into scala3-help
michelou 093e5ca
Merge remote-tracking branch 'upstream/master' into scala3-help
michelou 161b012
removed dependency on jline terminal
michelou 80e673f
Merge remote-tracking branch 'upstream/master' into scala3-help
michelou 33d8b63
added defaultPageWidth into ScalaSettings
michelou 5a257df
Merge remote-tracking branch 'upstream/master' into scala3-help
michelou fa6cbeb
Merge remote-tracking branch 'upstream/master' into scala3-help
michelou 30fca32
Merge remote-tracking branch 'upstream/master' into scala3-help
michelou 686c0d1
Merge remote-tracking branch 'upstream/master' into scala3-help
michelou 99c3f04
Merge remote-tracking branch 'upstream/master' into scala3-help
michelou 3f97991
Merge remote-tracking branch 'upstream/master' into scala3-help
michelou 4f825f6
sync with upstream
michelou 27fecd7
Merge remote-tracking branch 'upstream/master' into scala3-help
michelou 29c552d
improved readability of help messages
michelou 73e482a
removed dependency on jline terminal
michelou c0e1d6c
rebased with upstream
michelou 95229d4
Merge branch 'scala3-help' of https://github.com/michelou/dotty into …
michelou 5c82e3e
Merge remote-tracking branch 'upstream/master' into HEAD
michelou 0f7503c
sync with upstream
michelou 5059475
Merge remote-tracking branch 'upstream/master' into HEAD
michelou 5613181
Merge remote-tracking branch 'upstream/master' into HEAD
michelou 8316dc4
Merge remote-tracking branch 'upstream/master' into scala3-help
michelou 00bd288
sync with upstream, added tput
michelou 19d7024
added missing source file
michelou 6997b46
improved readability of help messages
michelou d330207
2nd attempt
michelou 3839dd2
Merge remote-tracking branch 'upstream/master' into scala3-help
michelou 3598d66
sync with upstream
michelou 056f47a
Merge remote-tracking branch 'upstream/master' into scala3-help
michelou a957a51
sync with upstream
michelou 3495899
Merge remote-tracking branch 'upstream/master' into scala3-help
michelou b9887ff
Merge remote-tracking branch 'upstream/master' into scala3-help
michelou abf5a9f
Merge remote-tracking branch 'upstream/master' into scala3-help
michelou 9e5f044
Merge remote-tracking branch 'upstream/master' into scala3-help
michelou 9ae830a
improved readability of help messages
michelou f714e36
removed dependency on jline terminal
michelou 40156d5
sync with upstream
michelou 5b2970c
improved readability of help messages
michelou 4ef48a9
removed dependency on jline terminal
michelou 5148a33
added defaultPageWidth into ScalaSettings
michelou 6c38e39
sync with upstream, added tput
michelou 49306d3
improved readability of help messages
michelou c743126
2nd attempt
michelou 8f73dae
sync with upstream
michelou 270fe25
Bring community build submodules up to date
griggt 1c03961
dist/bin/*.bat belong to another branch
michelou 640ed97
Merge branch 'scala3-help' of https://github.com/michelou/dotty into …
michelou 063e09a
Merge remote-tracking branch 'upstream/master' into scala3-help
michelou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Linux at least, this will not be set inside a shell script by default, the best portable way I've found to deal with that is to set it with:
in https://github.com/lampepfl/dotty/blob/master/dist/bin/common (I checked and that doesn't impact performance).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smarter I know that
tput
usage but I was hesitant to add it to the Scala 3 launch script. I'm fine if it's ok for you.I suggest the following change:
since it looks like running
tput
only once per session is enough to activate the automatic update of variableCOLUMNS
.Can you please confirm the above behavior in your Unix environment ?!
For instance (on your command line, after executing the above command):
$ set COLUMNS=
$ echo $COLUMNS
(should print the actual #columms in your terminal)$ echo $COLUMNS
(should print the updated #columms in your terminal)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will add your suggested code for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, looks like I forgot to answer here!
I think that the shell itself is responsible for updating $COLUMNS, if I'm in zsh or bash, $COLUMNS get updated automatically even if I reset it, but in dash for example it never gets updated.