Navigation displays only flatten package structure #10299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
abgruszecki
force-pushed
the
scala3doc/better-api-navigation
branch
from
bc2429e to
2e93d71
Compare
|
OK, I actually think that the stdlib hierarchy looks way better in this PR: Will merge once CI passes. |
abgruszecki
approved these changes
Nov 19, 2020
Classes, methods etc are not longer added to navigation
romanowski
force-pushed
the
scala3doc/better-api-navigation
branch
from
2e93d71 to
69ad6f8
Compare
abgruszecki
suggested changes
Nov 19, 2020
There was a problem hiding this comment.
Alright, correction: this PR actually seems to break unrolling navigation. Compare:
I guess that this is because classes are no longer items in navigation.
@romanowski I think we should fix that before merging this PR.
|
sure. good catch. I will take a look. |
abgruszecki
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes, methods etc are not longer added to navigation