remove scala.Enum type alias #10266
Merged
remove scala.Enum type alias #10266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
force-pushed
the
topic/enum-delete-scala-enum
branch
from
dd42488 to
5834cf8
Compare
|
@romanowski Hi, I'm not sure how to update the test in |
|
@bishabosha those tests are self-defined (we compare source with documentation) so you can rename it freely |
bishabosha
force-pushed
the
topic/enum-delete-scala-enum
branch
from
5834cf8 to
13b8bb6
Compare
|
@romanowski I believe I identified the problem is that the tests do not print the fully qualified path of types in signatures, so there requires two imports to unimport |
|
@smarter CI has passed |
smarter
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also removed some qualified types where not specifically testing how the compiler behaves for java.lang.Enum