Skip to content

Conversation

nicolasstucki
Copy link
Contributor

The library should not provide those operattion on Expr.
These can still be done using reflection and we keep testing that they can be encoded.

The library should not provide those operattion on Expr.
These can still be done using reflection and we keep testing that they can be encoded.
@nicolasstucki nicolasstucki marked this pull request as ready for review November 5, 2020 16:29
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice simplification 👍

@nicolasstucki nicolasstucki merged commit dd4d881 into scala:master Nov 6, 2020
@nicolasstucki nicolasstucki deleted the remove-UnsafeExpr branch November 6, 2020 12:19
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants