-
Notifications
You must be signed in to change notification settings - Fork 1.1k
community build: add scala-parallel-collections #10179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community build: add scala-parallel-collections #10179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
this is failing for two reasons: first, second, the scala-parallel-collections build requires sbt 1.4.1+ (to get the new built-in-support for |
This is because the current version of scalacheck in the community build is I'm the wrong person to be giving advice here, but will note that the other projects in the community build live in forks at https://github.com/dotty-staging/ and may contain adaptations to allow/keep them building inside the community build. On a positive note, I was able to get this to work in a locally built community build by tweaking the scalacheck version and unmanagedSourceDependencies in build.sbt. |
As mentioned by @griggt, we'll need to update the scalacheck submodule to 1.15, because we try to keep all our community-build projects on https://github.com/dotty-staging, this means creating or (non-destructively) updating a branch on https://github.com/dotty-staging/scalacheck/ (same thing for scala-parallel-collections itself: we should fork it to dotty-staging and add that fork as our submodule) I've given you access to dotty-staging if you're up for doing that, otherwise we'll take care of it.
You can change the forced version to 1.4.1 (I would avoid 1.4.2 due to sbt/sbt#6055) and see if everything works, I think that might require updating some other projects in the community build. Or you can add an extra commit in the fork of scala-parallel-collections in dotty-staging to make it not require sbt 1.4 |
thanks for the advice (and the powers) — I'll return to this before too much longer. marking as draft for now. |
PR to upgrade scalacheck: #10194 |
No description provided.