Skip to content

community build: add scala-parallel-collections #10179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2020
Merged

community build: add scala-parallel-collections #10179

merged 1 commit into from
Nov 19, 2020

Conversation

SethTisue
Copy link
Member

No description provided.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@SethTisue
Copy link
Member Author

this is failing for two reasons:

first, sbt.librarymanagement.ResolveException: Error downloading org.scalacheck:scalacheck_3.0.0-M2:1.15.0 — no idea what I'm expected to do here? I already included dependencies = List(scalacheck)

second, the scala-parallel-collections build requires sbt 1.4.1+ (to get the new built-in-support for src/main/scala-2 and src/main/scala-3 directories), but it appears to me that the community build forces the version to 1.3.8. is there a way to get a newer sbt version?

@griggt
Copy link
Contributor

griggt commented Nov 5, 2020

Error downloading org.scalacheck:scalacheck_3.0.0-M2:1.15.0

This is because the current version of scalacheck in the community build is 1.14.1-SNAPSHOT.

I'm the wrong person to be giving advice here, but will note that the other projects in the community build live in forks at https://github.com/dotty-staging/ and may contain adaptations to allow/keep them building inside the community build.

On a positive note, I was able to get this to work in a locally built community build by tweaking the scalacheck version and unmanagedSourceDependencies in build.sbt.

@smarter
Copy link
Member

smarter commented Nov 5, 2020

first, sbt.librarymanagement.ResolveException: Error downloading org.scalacheck:scalacheck_3.0.0-M2:1.15.0 — no idea what I'm expected to do here?

As mentioned by @griggt, we'll need to update the scalacheck submodule to 1.15, because we try to keep all our community-build projects on https://github.com/dotty-staging, this means creating or (non-destructively) updating a branch on https://github.com/dotty-staging/scalacheck/ (same thing for scala-parallel-collections itself: we should fork it to dotty-staging and add that fork as our submodule) I've given you access to dotty-staging if you're up for doing that, otherwise we'll take care of it.

second, the scala-parallel-collections build requires sbt 1.4.1+ (to get the new built-in-support for src/main/scala-2 and src/main/scala-3 directories), but it appears to me that the community build forces the version to 1.3.8. is there a way to get a newer sbt version?

You can change the forced version to 1.4.1 (I would avoid 1.4.2 due to sbt/sbt#6055) and see if everything works, I think that might require updating some other projects in the community build. Or you can add an extra commit in the fork of scala-parallel-collections in dotty-staging to make it not require sbt 1.4

@SethTisue SethTisue marked this pull request as draft November 5, 2020 18:17
@SethTisue
Copy link
Member Author

SethTisue commented Nov 5, 2020

thanks for the advice (and the powers) — I'll return to this before too much longer. marking as draft for now.

@smarter
Copy link
Member

smarter commented Nov 5, 2020

PR to upgrade scalacheck: #10194

@SethTisue SethTisue marked this pull request as ready for review November 7, 2020 04:55
@anatoliykmetyuk anatoliykmetyuk merged commit dfe6f3e into scala:master Nov 19, 2020
@SethTisue SethTisue deleted the add-parallel-collections branch November 19, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants