fix #9894: clean ownership when destructing lambda-expressions #10132
Conversation
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Add" instead of "Added")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
rssh
changed the title
| @@ -745,7 +746,9 @@ class QuoteContextImpl private (ctx: Context) extends QuoteContext: | |||
| def unapply(tree: Block): Option[(List[ValDef], Term)] = tree match { | |||
| case Block((ddef @ DefDef(_, _, params :: Nil, _, Some(body))) :: Nil, Closure(meth, _)) | |||
| if ddef.symbol == meth.symbol => | |||
| Some((params, body)) | |||
| val cleanParams = params.map(_.changeOwner(meth.symbol,ctx.owner)) | |||
| val cleanBody = body.changeOwner(meth.symbol,ctx.owner) | |||
There was a problem hiding this comment.
We cannot rely on this body being used inside ctx.owner. We need to change adapt it when we construct the Lambda. We have some logic that knows how to do this. I created an alternative fix that does just that in #10142.
There was a problem hiding this comment.
This fix was helped me understand the source of the issue. Thank you.
When destructing lambda-expression, cleanup ownership of its body to allow reusing body in the caller context.