Port ZipArchiveTest #10099
Merged
Port ZipArchiveTest #10099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PR: scala/scala#9230 - issue: scala/bug#11754 Co-authored-by: Som Snytt <[email protected]>
nicolasstucki
approved these changes
Oct 28, 2020
| archive.close() | ||
| // The following results in IOException on Windows (file in use by another process). | ||
| // As jar is a temp file, it will be deleted automatically. | ||
| // Files.delete(jar) |
There was a problem hiding this comment.
Maybe it is better to try to delete it
try Files.delete(jar) catch case _: IOException => ()There was a problem hiding this comment.
Or make it conditional using System.getProperty("os.name").
There was a problem hiding this comment.
This way we would at least test that we can delete it in a non-Windows OS.
There was a problem hiding this comment.
Do you know what is using the jar?
There was a problem hiding this comment.
It seems to be Windows-specific --- it should not be used as on Linux machines.
|
|
||
| private[this] var closeables: List[java.io.Closeable] = Nil | ||
| override def close(): Unit = { | ||
| closeables.foreach(_.close) |
There was a problem hiding this comment.
We can simpli
Suggested change
| closeables.foreach(_.close) | |
| closeables.foreach(_.close) | |
| closeables = Nil |
nicolasstucki
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test catches an infinite recursion in ZipArchive
Co-authored-by: Som Snytt [email protected]