Skip to content

Only run bootstrapped tests for the Windows CI #10026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

smarter
Copy link
Member

@smarter smarter commented Oct 16, 2020

They are a superset of the non-bootstrapped tests and bootstrapping
issues should be caught by the non-bootstrapped Linux runner.

They are a superset of the non-bootstrapped tests and bootstrapping
issues should be caught by the non-bootstrapped Linux runner.
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarter smarter merged commit 100931e into scala:master Oct 16, 2020
@smarter smarter deleted the simplify-windows-ci branch October 16, 2020 14:27
@michelou
Copy link
Contributor

michelou commented Oct 16, 2020

Another alternative : use more than 1 workflow file.

For instance (assuming an appropriate workflow filter) :

  • ci.yaml (linux) and
  • ci-win.yaml (environment variable ImageOS is win16 or win19).

Yet another alternative would be to use one of the github.event properties to choose between the above workflow files (e.g. a push message containing the word "windows" would fire ci-win.yaml).

@michelou
Copy link
Contributor

@smarter @liufengyun Here I'd like to emphasize the fact that the job test_boostrapped is not strictly a superset of test since bootstrapCmdTests (called at the end of the 1st job) is different from cmdTests (called in the 2nd job).

@smarter
Copy link
Member Author

smarter commented Oct 17, 2020

I don't think the windows CI runs either of those anyway because they're bash scripts, but it'd be nice if it did indeed.

@michelou
Copy link
Contributor

michelou commented Oct 17, 2020

@smarter As a reminder I'm running both batch files cmdTests and bootstrapCmdTests for over 2 years (at least since Dotty 0.7, yes Dotty 0.7) locally on my Win10 laptop (see description in BUILD.md).
If you check again the email I sent you in CC on October 16, 2020 (09h19), you will see the two batch files been executed in my GitHub Actions, for instance the run of October 15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants