Skip to content

Remove support for -language:_ #7575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolasstucki opened this issue Nov 18, 2019 · 1 comment
Closed

Remove support for -language:_ #7575

nicolasstucki opened this issue Nov 18, 2019 · 1 comment

Comments

@nicolasstucki
Copy link
Contributor

We should just remove support for -language:_, it doesn't mean anything useful. But even then, I think it's strange that some -language flags just turn off warnings whereas others change the semantics of the language (and are therefore much more dangerous), I think we should clearly separate these two sets of options, in particular turning off language warnings should look like turning off any other kind of warning (something like the -Wno-xxx options in clang/gcc ?)

Originally posted by @smarter in #6291 (comment)

nicolasstucki added a commit that referenced this issue Nov 20, 2019
@som-snytt
Copy link
Contributor

som-snytt commented Nov 4, 2020

-language:_ means don't hassle me with so-called options.

For -source options, it could mean take the latest available source level.

Otherwise, it could mean "enable ALL the things!" if those settings are not in conflict.

With -Wconf, one could re-imagine language features as aliases for -Wconf. There is a sense in which -Wconf is more expensive than the language feature look-up, so there could be a cost. Maybe that's an implementation detail.

Edit: it's mentioned on the linked ticket that language options can mean semantic differences that aren't reducible to errors. Even if they were, it's not obvious that reporting has enough context to say, "They used feature L, emit a warning if language.L is not enabled." Or, maybe there is a clever way to emit, "Did you remember to enable language.L?" and then that is "suppressed" if it is enabled. Like "Did you remember to sign the CLA?" and other annoyances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants