Skip to content

Slight performance regressions in recent PRs #3721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smarter opened this issue Dec 31, 2017 · 1 comment
Closed

Slight performance regressions in recent PRs #3721

smarter opened this issue Dec 31, 2017 · 1 comment
Assignees
@odersky
Labels
itype:performance itype:question prio:low

Comments

@smarter
Copy link
Member

smarter commented Dec 31, 2017

Looking at http://dotty-bench.epfl.ch/ it looks like we've become about ~2% slower on some of the tests recently. It's hard to see due the variance but I think the following PRs are responsible for this:

I'm opening this issue because I think it would be nice to know why these PRs had a performance impact and whether this can be mitigated in some way. 2% isn't a big deal so if we can't figure it out we can just close the issue.
@odersky odersky self-assigned this Jan 18, 2018
odersky added a commit to dotty-staging/dotty that referenced this issue Jan 18, 2018
@odersky
Add quoted.Type.apply
e6664ed 
This is intended as a stub. Calls to this method will be replaced
by implicit type tag searches.

Also, rework definition of quote and splice methods. This could also
have contributed in the slowdown we were seeing in scala#3721.
@odersky odersky mentioned this issue Jan 19, 2018
Merged
odersky added a commit to dotty-staging/dotty that referenced this issue Jan 21, 2018
@odersky
Add quoted.Type.apply
f33aa0e 
This is intended as a stub. Calls to this method will be replaced
by implicit type tag searches.

Also, rework definition of quote and splice methods. This could also
have contributed in the slowdown we were seeing in scala#3721.
odersky added a commit to dotty-staging/dotty that referenced this issue Jan 27, 2018
@odersky
Add quoted.Type.apply
5125c8e 
This is intended as a stub. Calls to this method will be replaced
by implicit type tag searches.

Also, rework definition of quote and splice methods. This could also
have contributed in the slowdown we were seeing in scala#3721.
@odersky
Copy link
Contributor

odersky commented Jan 27, 2018

This will be fixed by #3866.

@odersky odersky closed this as completed Jan 27, 2018
odersky added a commit that referenced this issue Feb 2, 2018
@odersky
Merge pull request #3868 from dotty-staging/fix-#3721
cbaa827 
Fix #3721: Roll back SubstMap functionality into general TreeTypeMap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odersky odersky

Labels
itype:performance itype:question prio:low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smarter @odersky