Skip to content

Performance regression in the flat classpath #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smarter opened this issue Apr 27, 2017 · 2 comments
Closed

Performance regression in the flat classpath #2317

smarter opened this issue Apr 27, 2017 · 2 comments
Labels
area:classpath exp:advanced itype:performance prio:low

Comments

@smarter
Copy link
Member

smarter commented Apr 27, 2017

scala/bug#10289 should affect us too now that we've update our classpath implementation (#2191).
@smarter smarter mentioned this issue Apr 27, 2017
Merged
@smarter
Copy link
Member Author

smarter commented Jun 22, 2017

There is now a fix in scalac for the aforementioned bug: scala/scala#5956 The culprit turned out to be findClass which is used by the sbt scalac bridge. Since the sbt dotty bridge does not use findClass, it is likely that we are not affected by this regression after all, but we should still port the classpath implementation changes.

@smarter
Copy link
Member Author

smarter commented Dec 10, 2017 •
edited
Loading

Fixed in #3116

@smarter smarter closed this as completed Dec 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:classpath exp:advanced itype:performance prio:low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smarter