Skip to content

TreeTypeMap and MiniPhases have an architectural problem #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
felixmulder opened this issue Apr 4, 2017 · 2 comments
Closed

TreeTypeMap and MiniPhases have an architectural problem #2174

felixmulder opened this issue Apr 4, 2017 · 2 comments
Assignees
@smarter
Labels
area:transform exp:expert itype:bug

Comments

@felixmulder
Copy link
Contributor

felixmulder commented Apr 4, 2017 •
edited
Loading

See illustration in #1770
@odersky
Copy link
Contributor

odersky commented Jan 24, 2018

I don't think there are actionable items for this in the foreseeable future. If someone wants to redesign this at some point, we can re-open.

@odersky odersky closed this as completed Jan 24, 2018
@smarter
Copy link
Member

smarter commented Jan 24, 2018

We now always run mini-phases tree transforms with ctx.phase set to be at the group end, so I think this is actually fixed in practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smarter smarter

Labels
area:transform exp:expert itype:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smarter @odersky @felixmulder