Skip to content

scaladoc inserts -project-logo twice #16693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alanbur opened this issue Jan 13, 2023 · 1 comment · Fixed by #17170
Closed

scaladoc inserts -project-logo twice #16693

alanbur opened this issue Jan 13, 2023 · 1 comment · Fixed by #17170
Labels
area:doctool itype:bug Spree Suitable for a future Spree
Milestone
3.3.1

Comments

@alanbur
Copy link

alanbur commented Jan 13, 2023 •
edited
Loading

Scaladoc version 3.2.1 -- Copyright 2002-2022, LAMP/EPFL

Using the -project-logo command line flag results in the logo being included twice in the generated HTML, and it being displayed twice.

Screenshot_2023-01-13_22-45-11
@alanbur alanbur added itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label labels Jan 13, 2023
@KacperFKorban KacperFKorban added area:doctool and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Jan 14, 2023
@SethTisue SethTisue added the Spree Suitable for a future Spree label Jan 19, 2023
little-inferno added a commit to little-inferno/dotty that referenced this issue Jan 19, 2023
@little-inferno
Fix scala#16693 scaladoc inserts -project-logo twice
6af5fcd
little-inferno added a commit to little-inferno/dotty that referenced this issue Jan 19, 2023
@little-inferno
Fix scala#16693 scaladoc inserts -project-logo twice
5bafe5c
little-inferno added a commit to little-inferno/dotty that referenced this issue Jan 19, 2023
@little-inferno
Fix scala#16693 scaladoc inserts -project-logo twice
a276281
little-inferno added a commit to little-inferno/dotty that referenced this issue Jan 19, 2023
@little-inferno
Fix scala#16693 scaladoc inserts -project-logo twice
e1d979c
little-inferno added a commit to little-inferno/dotty that referenced this issue Jan 25, 2023
@little-inferno
Fix scala#16693 scaladoc inserts -project-logo twice
42b3042
little-inferno added a commit to little-inferno/dotty that referenced this issue Jan 25, 2023
@little-inferno
Fix scala#16693 scaladoc inserts -project-logo twice
fcfd44e
@Dedelweiss
Copy link
Contributor

Hello, I see that there are some attempts to solve this problem, can I try to fix it?

This was referenced Mar 29, 2023
Merged
Closed
ckipp01 pushed a commit that referenced this issue Mar 30, 2023
@Dedelweiss
Fix: Remove the duplicate logo (#17170)
cabfa68 
- I added an orElse to the snippet so that the dark logo works and there
is no duplicate logo.
### Before
<img width="569" alt="Screenshot 2023-03-29 at 14 51 09"
src="https://user-images.githubusercontent.com/44496264/228541357-77ca6c2a-4413-45fd-a283-40f304d88c4a.png">
### After 
<img width="569" alt="Screenshot 2023-03-29 at 14 48 22"
src="https://user-images.githubusercontent.com/44496264/228541334-c9a3eccc-1d4a-475b-b03b-3698bde162fb.png">

Fixes: #16693
Dedelweiss added a commit to Dedelweiss/dotty that referenced this issue Apr 17, 2023
@Dedelweiss
Fix: Remove the duplicate logo (scala#17170)
746cc13 
- I added an orElse to the snippet so that the dark logo works and there
is no duplicate logo.
### Before
<img width="569" alt="Screenshot 2023-03-29 at 14 51 09"
src="https://user-images.githubusercontent.com/44496264/228541357-77ca6c2a-4413-45fd-a283-40f304d88c4a.png">
### After 
<img width="569" alt="Screenshot 2023-03-29 at 14 48 22"
src="https://user-images.githubusercontent.com/44496264/228541334-c9a3eccc-1d4a-475b-b03b-3698bde162fb.png">

Fixes: scala#16693
@Kordyjan Kordyjan added this to the 3.3.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:doctool itype:bug Spree Suitable for a future Spree
Projects
None yet
Milestone
3.3.1
Development

Successfully merging a pull request may close this issue.

Fix: Remove the duplicate logo Dedelweiss/dotty
5 participants
@SethTisue @alanbur @Kordyjan @KacperFKorban @Dedelweiss