Skip to content

Rename Eql to CanEqual #10415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odersky opened this issue Nov 20, 2020 · 2 comments · Fixed by #10449
Closed

Rename Eql to CanEqual #10415

odersky opened this issue Nov 20, 2020 · 2 comments · Fixed by #10449
Assignees
@odersky
Milestone
3.0.0

Comments

@odersky
Copy link
Contributor

odersky commented Nov 20, 2020

Eql is a typeclass used in multi-versal equality to check that regular universal equality == is allowed. I believe therefore that CanEqual is a better name. That way, we do not raise the expectation that this is some sort of equality typeclass. And we avoid confusion and possible nameclashes if oneone we want to introduce an equality typeclass ourselves.
@odersky odersky added this to the 3.0.0-RC1 milestone Nov 20, 2020
@sjrd
Copy link
Member

sjrd commented Nov 23, 2020

This probably deserves a Contributors post, this late. Or at least tagging library maintainers who may have a skin in that game?

@odersky odersky self-assigned this Nov 23, 2020
@odersky
Copy link
Contributor Author

odersky commented Nov 23, 2020

No code in the community build seems to have used this yet.

@nicolasstucki nicolasstucki linked a pull request Nov 23, 2020 that will close this issue
Fix #10415: Use CanEqual instead of Eql for multiversal equality #10449
Merged
bishabosha added a commit that referenced this issue Nov 24, 2020
@bishabosha
Merge pull request #10449 from dotty-staging/fix-#10415
7f2c4f6 
Fix #10415: Use `CanEqual` instead of `Eql` for multiversal equality
@Kordyjan Kordyjan modified the milestones: 3.0.0-M3, 3.0.0 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odersky odersky

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Fix #10415: Use CanEqual instead of Eql for multiversal equality dotty-staging/dotty
3 participants
@sjrd @odersky @Kordyjan