Merge pull request #10721 from dotty-staging/remove-language-forking-settings

Remove settings that fork the binary ecosystem

Author: sjrd

compiler/src/dotty/tools/dotc/config/ScalaSettings.scala

@@ -118,7 +118,6 @@ class ScalaSettings extends Settings.SettingGroup with CommonScalaSettings {
   val XprintSuspension: Setting[Boolean] = BooleanSetting("-Xprint-suspension", "Show when code is suspended until macros are compiled.")
   val Xprompt: Setting[Boolean] = BooleanSetting("-Xprompt", "Display a prompt after each error (debugging option).")
   val XshowPhases: Setting[Boolean] = BooleanSetting("-Xshow-phases", "Print all compiler phases.")
-  val XnoValueClasses: Setting[Boolean] = BooleanSetting("-Xno-value-classes", "Do not use value classes. Helps debugging.")
   val XreplLineWidth: Setting[Int] = IntSetting("-Xrepl-line-width", "Maximal number of columns per line for REPL output.", 390)
   val XreplDisableDisplay: Setting[Boolean] = BooleanSetting("-Xrepl-disable-display", "Do not display definitions in REPL.")
   val XfatalWarnings: Setting[Boolean] = BooleanSetting("-Xfatal-warnings", "Fail the compilation if there are any warnings.")
@@ -161,7 +160,6 @@ class ScalaSettings extends Settings.SettingGroup with CommonScalaSettings {
   val Yscala2Unpickler: Setting[String] = StringSetting("-Yscala2-unpickler", "", "Control where we may get Scala 2 symbols from. This is either \"always\", \"never\", or a classpath.", "always")
 
   val YnoImports: Setting[Boolean] = BooleanSetting("-Yno-imports", "Compile without importing scala.*, java.lang.*, or Predef.")
-  val YnoInline: Setting[Boolean] = BooleanSetting("-Yno-inline", "Suppress inlining.")
   val YnoGenericSig: Setting[Boolean] = BooleanSetting("-Yno-generic-signatures", "Suppress generation of generic signatures for Java.")
   val YnoPredef: Setting[Boolean] = BooleanSetting("-Yno-predef", "Compile without importing Predef.")
   val Yskip: Setting[List[String]] = PhasesSetting("-Yskip", "Skip")

compiler/src/dotty/tools/dotc/transform/Memoize.scala

@@ -129,7 +129,7 @@ class Memoize extends MiniPhase with IdentityDenotTransformer { thisPhase =>
         cpy.installAfter(thisPhase)
       }
 
-    val NoFieldNeeded = Lazy | Deferred | JavaDefined | (if (ctx.settings.YnoInline.value) EmptyFlags else Inline)
+    val NoFieldNeeded = Lazy | Deferred | JavaDefined | Inline
 
     def erasedBottomTree(sym: Symbol) =
       if (sym eq defn.NothingClass) Throw(nullLiteral)

compiler/src/dotty/tools/dotc/transform/ValueClasses.scala

@@ -15,7 +15,6 @@ object ValueClasses {
 
   def isDerivedValueClass(sym: Symbol)(using Context): Boolean = {
     val d = sym.denot
-    !ctx.settings.XnoValueClasses.value &&
     !d.isRefinementClass &&
     d.isValueClass &&
     (d.initial.symbol ne defn.AnyValClass) && // Compare the initial symbol because AnyVal does not exist after erasure

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -3283,9 +3283,7 @@ class Typer extends Namer
       }
       else if (methPart(tree).symbol.isAllOf(Inline | Deferred) && !Inliner.inInlineMethod) then
         errorTree(tree, i"Deferred inline ${methPart(tree).symbol.showLocated} cannot be invoked")
-      else if (Inliner.isInlineable(tree) &&
-               !ctx.settings.YnoInline.value &&
-               !suppressInline) {
+      else if (Inliner.isInlineable(tree) && !suppressInline) {
         tree.tpe <:< wildApprox(pt)
         val errorCount = ctx.reporter.errorCount
         val meth = methPart(tree).symbol

doc-tool/src/dotty/tools/dottydoc/DocDriver.scala

@@ -26,7 +26,6 @@ class DocDriver extends Driver {
 
     ctx.setSettings(summary.sstate)
     ctx.setSetting(ctx.settings.YcookComments, true)
-    ctx.setSetting(ctx.settings.YnoInline, true)
     ctx.setProperty(ContextDoc, new ContextDottydoc)
 
     val fileNames = CompilerCommand.checkUsage(summary, sourcesRequired)(using ctx)

doc-tool/test/dotty/tools/dottydoc/DottyDocTest.scala

@@ -32,7 +32,6 @@ trait DottyDocTest extends MessageRendering {
     ctx.setSetting(ctx.settings.language, List("Scala2"))
     ctx.setSetting(ctx.settings.YcookComments, true)
     ctx.setSetting(ctx.settings.Ycheck, "all" :: Nil)
-    ctx.setSetting(ctx.settings.YnoInline, true)
     ctx.setSetting(ctx.settings.wikiSyntax, true)
     ctx.setProperty(ContextDoc, new ContextDottydoc)
     ctx.setSetting(

doc-tool/test/dotty/tools/dottydoc/MarkdownTests.scala

@@ -18,7 +18,6 @@ class MarkdownTests extends DottyDocTest with CheckFromSource {
     val ctx = base.initialCtx.fresh
     ctx.setSetting(ctx.settings.language, List("Scala2"))
     ctx.setSetting(ctx.settings.YcookComments, true)
-    ctx.setSetting(ctx.settings.YnoInline, true)
     ctx.setSetting(ctx.settings.Ycheck, "all" :: Nil)
     // No wiki syntax!
     ctx.setSetting(ctx.settings.wikiSyntax, false)