Skip to content

Commit 5160817

Browse files
nicolasstuckinicolasstucki
committed
Introduce Typed abstraction that supports patterns
1 parent af257eb commit 5160817

File tree

16 files changed

+131
-38
lines changed

16 files changed

+131
-38
lines changed

‎compiler/src/scala/quoted/runtime/impl/Matcher.scala‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ object Matcher {
178178

179179
/* Term hole */
180180
// Match a scala.internal.Quoted.patternHole typed as a repeated argument and return the scrutinee tree
181-
case (scrutinee @ Typed(s: Term, tpt1), Typed(TypeApply(patternHole, tpt :: Nil), tpt2))
181+
case (scrutinee @ Typed(s, tpt1), Typed(TypeApply(patternHole, tpt :: Nil), tpt2))
182182
if patternHole.symbol == patternHoleSymbol &&
183183
s.tpe <:< tpt.tpe &&
184184
tpt2.tpe.derivesFrom(defn.RepeatedParamClass) =>

‎compiler/src/scala/quoted/runtime/impl/QuotesImpl.scala‎

Lines changed: 37 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -333,10 +333,18 @@ class QuotesImpl private (using val ctx: Context) extends Quotes, QuoteUnpickler
333333

334334
object TermTypeTest extends TypeTest[Tree, Term]:
335335
def unapply(x: Tree): Option[Term & x.type] = x match
336+
case x: (tpd.Ident & x.type) =>
337+
if x.isTerm && x.name != nme.WILDCARD then Some(x)
338+
else None
339+
case x: (tpd.Typed & x.type) =>
340+
// Matches `Typed` but not `TypedTree`
341+
TypedTypeTest.unapply(x)
336342
case x: (tpd.SeqLiteral & x.type) => Some(x)
337343
case x: (tpd.Inlined & x.type) => Some(x)
338344
case x: (tpd.NamedArg & x.type) => Some(x)
339-
case _ => if x.isTerm then Some(x) else None
345+
case _ =>
346+
if x.isTerm then Some(x)
347+
else None
340348
end TermTypeTest
341349

342350
object Term extends TermModule:
@@ -646,7 +654,10 @@ class QuotesImpl private (using val ctx: Context) extends Quotes, QuoteUnpickler
646654

647655
object TypedTypeTest extends TypeTest[Tree, Typed]:
648656
def unapply(x: Tree): Option[Typed & x.type] = x match
649-
case x: (tpd.Typed & x.type) => Some(x)
657+
case x: (tpd.Typed & x.type) =>
658+
x.expr match
659+
case TermTypeTest(_) => Some(x)
660+
case _ => None
650661
case _ => None
651662
end TypedTypeTest
652663

@@ -1412,6 +1423,30 @@ class QuotesImpl private (using val ctx: Context) extends Quotes, QuoteUnpickler
14121423
def unapply(pattern: Wildcard): true = true
14131424
end Wildcard
14141425

1426+
type TypedTree = tpd.Typed
1427+
1428+
object TypedTreeTypeTest extends TypeTest[Tree, TypedTree]:
1429+
def unapply(x: Tree): Option[TypedTree & x.type] = x match
1430+
case x: (tpd.Typed & x.type) => Some(x)
1431+
case _ => None
1432+
end TypedTreeTypeTest
1433+
1434+
object TypedTree extends TypedTreeModule:
1435+
def apply(expr: Term, tpt: TypeTree): Typed =
1436+
withDefaultPos(tpd.Typed(xCheckMacroValidExpr(expr), tpt))
1437+
def copy(original: Tree)(expr: Term, tpt: TypeTree): Typed =
1438+
tpd.cpy.Typed(original)(xCheckMacroValidExpr(expr), tpt)
1439+
def unapply(x: Typed): (Term, TypeTree) =
1440+
(x.expr, x.tpt)
1441+
end TypedTree
1442+
1443+
given TypedTreeMethods: TypedTreeMethods with
1444+
extension (self: Typed)
1445+
def tree: Tree = self.expr
1446+
def tpt: TypeTree = self.tpt
1447+
end extension
1448+
end TypedTreeMethods
1449+
14151450
type Bind = tpd.Bind
14161451

14171452
object BindTypeTest extends TypeTest[Tree, Bind]:

‎compiler/src/scala/quoted/runtime/impl/printers/Extractors.scala‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,8 @@ object Extractors {
173173
this += "Unapply(" += fun += ", " ++= implicits += ", " ++= patterns += ")"
174174
case Alternatives(patterns) =>
175175
this += "Alternatives(" ++= patterns += ")"
176+
case TypedTree(tree, tpt) =>
177+
this += "TypedTree(" += tree += ", " += tpt += ")"
176178
}
177179

178180
def visitConstant(x: Constant): this.type = x match {

‎compiler/src/scala/quoted/runtime/impl/printers/SourceCode.scala‎

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -453,6 +453,15 @@ object SourceCode {
453453
printTypeOrAnnots(tpt.tpe)
454454
}
455455
}
456+
case TypedTree(tree1, tpt) =>
457+
printPattern(tree1)
458+
tree1 match
459+
case Wildcard() =>
460+
this += ":"
461+
printType(tpt.tpe)
462+
case _ => // Alternatives, Unapply, Bind
463+
this
464+
456465

457466
case Assign(lhs, rhs) =>
458467
printTree(lhs)
@@ -928,9 +937,13 @@ object SourceCode {
928937
case Alternatives(trees) =>
929938
inParens(printPatterns(trees, " | "))
930939

931-
case Typed(Wildcard(), tpt) =>
932-
this += "_: "
933-
printTypeTree(tpt)
940+
case TypedTree(tree1, tpt) =>
941+
tree1 match
942+
case Wildcard() =>
943+
this += "_: "
944+
printTypeTree(tpt)
945+
case _ =>
946+
printPattern(tree1)
934947

935948
case v: Term =>
936949
printTree(v)

‎library/src/scala/quoted/ExprMap.scala‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ trait ExprMap:
5656
tree
5757
case New(tpt) =>
5858
New.copy(tree)(transformTypeTree(tpt)(owner))
59-
case Typed(expr: Term, tpt) =>
59+
case Typed(expr, tpt) =>
6060
val tp = tpt.tpe match
6161
case AppliedType(TypeRef(ThisType(TypeRef(NoPrefix(), "scala")), "<repeated>"), List(tp0: TypeRepr)) =>
6262
TypeRepr.of[Seq].appliedTo(tp0)

‎library/src/scala/quoted/FromExpr.scala‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ object FromExpr {
8686
def rec(tree: Term): Option[T] = tree match {
8787
case Block(stats, e) => if stats.isEmpty then rec(e) else None
8888
case Inlined(_, bindings, e) => if bindings.isEmpty then rec(e) else None
89-
case Typed(e: Term, _) => rec(e)
89+
case Typed(e, _) => rec(e)
9090
case _ =>
9191
tree.tpe.widenTermRefByName match
9292
case ConstantType(c) => Some(c.value.asInstanceOf[T])

‎library/src/scala/quoted/Quotes.scala‎

Lines changed: 61 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ trait Quotes { self: runtime.QuoteUnpickler & runtime.QuoteMatching =>
122122
* | +- Apply
123123
* | +- TypeApply
124124
* | +- Super
125-
* | +- Typed
126125
* | +- Assign
127126
* | +- Block
128127
* | +- Closure
@@ -135,7 +134,16 @@ trait Quotes { self: runtime.QuoteUnpickler & runtime.QuoteMatching =>
135134
* | +- Inlined
136135
* | +- SelectOuter
137136
* | +- While
137+
* | +---+- Typed
138+
* | /
139+
* +- TypedTree +------------------·
140+
* +- Wildcard
141+
* +- Bind
142+
* +- Unapply
143+
* +- Alternatives
138144
* |
145+
* +- CaseDef
146+
* +- TypeCaseDef
139147
* |
140148
* +- TypeTree ----+- Inferred
141149
* | +- TypeIdent
@@ -153,14 +161,6 @@ trait Quotes { self: runtime.QuoteUnpickler & runtime.QuoteMatching =>
153161
* |
154162
* +- TypeBoundsTree
155163
* +- WildcardTypeTree
156-
* |
157-
* +- CaseDef
158-
* |
159-
* +- TypeCaseDef
160-
* +- Wildcard
161-
* +- Bind
162-
* +- Unapply
163-
* +- Alternatives
164164
*
165165
* +- ParamClause -+- TypeParamClause
166166
* +- TermParamClause
@@ -1094,22 +1094,26 @@ trait Quotes { self: runtime.QuoteUnpickler & runtime.QuoteMatching =>
10941094
/** `TypeTest` that allows testing at runtime in a pattern match if a `Tree` is a `Typed` */
10951095
given TypedTypeTest: TypeTest[Tree, Typed]
10961096

1097-
/** Tree representing a type ascription `x: T` in the source code */
1098-
type Typed <: Term
1097+
/** Tree representing a type ascription `x: T` in the source code.
1098+
*
1099+
* Also represents a pattern that contains a term `x`.
1100+
* Other `: T` patterns use the more general `TypeTree`.
1101+
*/
1102+
type Typed <: Term & TypeTree
10991103

11001104
/** Module object of `type Typed` */
11011105
val Typed: TypedModule
11021106

11031107
/** Methods of the module object `val Typed` */
11041108
trait TypedModule { this: Typed.type =>
11051109

1106-
/** Create a type ascription `<x: Tree>: <tpt: TypeTree>` */
1107-
def apply(expr: Tree, tpt: TypeTree): Typed
1110+
/** Create a type ascription `<x: Term>: <tpt: TypeTree>` */
1111+
def apply(expr: Term, tpt: TypeTree): Typed
11081112

1109-
def copy(original: Tree)(expr: Tree, tpt: TypeTree): Typed
1113+
def copy(original: Tree)(expr: Term, tpt: TypeTree): Typed
11101114

1111-
/** Matches `<expr: Tree>: <tpt: TypeTree>` */
1112-
def unapply(x: Typed): (Tree, TypeTree)
1115+
/** Matches `<expr: Term>: <tpt: TypeTree>` */
1116+
def unapply(x: Typed): (Term, TypeTree)
11131117
}
11141118

11151119
/** Makes extension methods on `Typed` available without any imports */
@@ -1118,7 +1122,7 @@ trait Quotes { self: runtime.QuoteUnpickler & runtime.QuoteMatching =>
11181122
/** Extension methods of `Typed` */
11191123
trait TypedMethods:
11201124
extension (self: Typed)
1121-
def expr: Tree
1125+
def expr: Term
11221126
def tpt: TypeTree
11231127
end extension
11241128
end TypedMethods
@@ -2038,6 +2042,41 @@ trait Quotes { self: runtime.QuoteUnpickler & runtime.QuoteMatching =>
20382042
def unapply(pattern: Wildcard): true
20392043
}
20402044

2045+
/** `TypeTest` that allows testing at runtime in a pattern match if a `Tree` is a `TypedTree` */
2046+
given TypedTreeTypeTest: TypeTest[Tree, TypedTree]
2047+
2048+
/** Tree representing a type ascription or pattern `x: T` in the source code
2049+
*
2050+
* The tree `x` may contain a `Constant`, `Ref`, `Wildcard`, `Bind`, `Unapply` or `Alternatives`.
2051+
*/
2052+
type TypedTree <: Term
2053+
2054+
/** Module object of `type TypedTree` */
2055+
val TypedTree: TypedTreeModule
2056+
2057+
/** Methods of the module object `val TypedTree` */
2058+
trait TypedTreeModule { this: TypedTree.type =>
2059+
2060+
/** Create a type ascription `<x: Tree>: <tpt: TypeTree>` */
2061+
def apply(expr: Tree, tpt: TypeTree): TypedTree
2062+
2063+
def copy(original: Tree)(expr: Tree, tpt: TypeTree): TypedTree
2064+
2065+
/** Matches `<expr: Tree>: <tpt: TypeTree>` */
2066+
def unapply(x: TypedTree): (Tree, TypeTree)
2067+
}
2068+
2069+
/** Makes extension methods on `TypedTree` available without any imports */
2070+
given TypedTreeMethods: TypedTreeMethods
2071+
2072+
/** Extension methods of `TypedTree` */
2073+
trait TypedTreeMethods:
2074+
extension (self: TypedTree)
2075+
def tree: Tree
2076+
def tpt: TypeTree
2077+
end extension
2078+
end TypedTreeMethods
2079+
20412080
/** Pattern representing a `_ @ _` binding. */
20422081
type Bind <: Tree
20432082

@@ -4265,6 +4304,8 @@ trait Quotes { self: runtime.QuoteUnpickler & runtime.QuoteMatching =>
42654304
case Bind(_, body) => foldTree(x, body)(owner)
42664305
case Unapply(fun, implicits, patterns) => foldTrees(foldTrees(foldTree(x, fun)(owner), implicits)(owner), patterns)(owner)
42674306
case Alternatives(patterns) => foldTrees(x, patterns)(owner)
4307+
case TypedTree(tree1, tpt) => foldTree(foldTree(x, tree1)(owner), tpt)(owner)
4308+
42684309
}
42694310
}
42704311
end TreeAccumulator
@@ -4329,6 +4370,8 @@ trait Quotes { self: runtime.QuoteUnpickler & runtime.QuoteMatching =>
43294370
Unapply.copy(pattern)(transformTerm(pattern.fun)(owner), transformSubTrees(pattern.implicits)(owner), transformTrees(pattern.patterns)(owner))
43304371
case pattern: Alternatives =>
43314372
Alternatives.copy(pattern)(transformTrees(pattern.patterns)(owner))
4373+
case TypedTree(expr, tpt) =>
4374+
TypedTree.copy(tree)(transformTree(expr)(owner), transformTypeTree(tpt)(owner))
43324375
}
43334376
}
43344377

@@ -4379,7 +4422,7 @@ trait Quotes { self: runtime.QuoteUnpickler & runtime.QuoteMatching =>
43794422
case New(tpt) =>
43804423
New.copy(tree)(transformTypeTree(tpt)(owner))
43814424
case Typed(expr, tpt) =>
4382-
Typed.copy(tree)(transformTree(expr)(owner), transformTypeTree(tpt)(owner))
4425+
Typed.copy(tree)(transformTerm(expr)(owner), transformTypeTree(tpt)(owner))
43834426
case tree: NamedArg =>
43844427
NamedArg.copy(tree)(tree.name, transformTerm(tree.value)(owner))
43854428
case Assign(lhs, rhs) =>

‎library/src/scala/quoted/Varargs.scala‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ object Varargs {
4242
import quotes.reflect._
4343
def rec(tree: Term): Option[Seq[Expr[T]]] = tree match {
4444
case Repeated(elems, _) => Some(elems.map(x => x.asExpr.asInstanceOf[Expr[T]]))
45-
case Typed(e: Term, _) => rec(e)
45+
case Typed(e, _) => rec(e)
4646
case Block(Nil, e) => rec(e)
4747
case Inlined(_, Nil, e) => rec(e)
4848
case _ => None

‎tests/neg-macros/i11483/Macro_1.scala‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ object X {
5151
)
5252
case Apply(f,List()) =>
5353
Apply(TypeApply(Select.unique(m,"pure"),List(Inferred(t.tpe.widen))),List(t))
54-
case Typed(x: Term,tp) => Typed(processTree(x,m), Inferred(TypeRepr.of[F].appliedTo(tp.tpe)) )
54+
case Typed(x,tp) => Typed(processTree(x,m), Inferred(TypeRepr.of[F].appliedTo(tp.tpe)) )
5555
case _ => throw new RuntimeException(s"tree not recoginized: $t")
5656
r
5757

‎tests/pos-macros/i10910/Macro_1.scala‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ object X:
4848
case Inlined(x,bindings,body) => transform(body) match
4949
case Left(unchanged) => Left(term)
5050
case Right(changed) => Right(Inlined(x,bindings,changed))
51-
case Typed(arg: Term,tp) => transform(arg)
51+
case Typed(arg,tp) => transform(arg)
5252
case Ident(x) => Left(term)
5353
case l@Literal(x) => Left(l)
5454
case other =>

0 commit comments

Comments
 (0)