-
Notifications
You must be signed in to change notification settings - Fork 3.1k
SI-10033 First round of deprecation cleanups for 2.13 #5515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This shaves off 11% of the jar size. 5.5MB -> 4.9MB. |
I would like to run the community build against this, but we don't quite have the 2.13.x community build in good enough shape yet — fixes are in progress on macro-paradise, genjavadoc, etc. |
Great! It would be really really nice if we could split this up in phases, and do the deprecations that don't break the community build first (most of them look like pure wins), but I'm afraid removing e.g., |
We can also remove some parts of the community build to make this task easier, but we should be able to build at least the core of the eco-system on 2.13.x by the end of the year. |
@adriaanm How can I figure out which changes break the community build?
Yes, that's the intention. I tried to avoid most things that looked dangerous in this PR. This PR has only a small subset of pending removals.
Will restore |
ah sorry, meant to abort the job of the closed pr. my bad! |
/rebuild |
Weird, I got the right job, but somehow it's reported here. (Ah, they have the same sha but different target branch) |
Thanks! Let's see what the ScalaCheck tests tell us. On my local machine I get error messages as if ScalaCheck wasn't there. This might be a result of the recent out-sourcing of ScalaCheck? |
This addresses most of the low-hanging fruits in the standard library.
Scalacheck tests pass on the CI! Can you reproduce the error from a clean build? |
@adriaanm That depends on how Florida votes. Otherwise I get some well-deserved sleep and try to reproduce it tomorrow. :-) |
You can run the community build locally: https://github.com/scala/community-builds/wiki/Maintenance#local-runs You can also open an issue or PR in that repo and request that we trigger a Jenkins run. (Ideally if you opened a PR, Scabot would do a Jenkins run for you; that's scala/scala-jenkins-infra#92) |
Also, please drop my name from the CLA list and notify me when it is done. |
This addresses most of the low-hanging fruits in the standard library.