SI-8965 Account for corner case in "unrelated types" warning #4102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review by @adriaanm |
| // a.scala:2: warning: Any and Any are unrelated: they will most likely never compare equal | ||
| // def f(x: Any with AnyRef, y: Any with AnyRef) = x eq y | ||
| // ^ | ||
| // one warning found |
There was a problem hiding this comment.
Needs -Xfatal-warnings to fail, since IIRC pos tests don't have check files that are checked. Though FSR there are check files under pos.
There was a problem hiding this comment.
Good catch, I've pushed a flags file.
It's okay for the two types to LUB to something above `Object` if they both individially were its supertype.
|
LGTM |
lrytz
added a commit
that referenced
this pull request
Nov 10, 2014
SI-8965 Account for corner case in "unrelated types" warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's okay for the two types to LUB to something above
Objectif they both individially were its supertype.