SI-8233 Fix regression in backend with boxed nulls #3462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I checked SI-8223 and there's no mention of null in that ticket. Is it some other ticket you meant? |
|
It's SI-8233 |
|
We should really automate JIRA <> GitHub synch. I tried enabling it some time ago, but it doesn't work and I don't even know where to start in fixing it. |
|
Yeah that's the one. It's a regression from 2.10 from jet brains. Another report coming from Alexander tomorrow. |
|
@retronym: please fix the ticket number in the diff. Other than that LGTM. |
Regressed in SI-7015 / 1b6661b. We do need to "unbox" the null (ie, drop a stack from and load a null) in general. The only time we can avoid this is if the tree we are adapting is a `Constant(Literal(null))`. I've added a test for both backends. Only GenICode exhibited the problem.
|
updated |
adriaanm
added a commit
that referenced
this pull request
Feb 5, 2014
SI-8233 Fix regression in backend with boxed nulls
This was referenced Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed in SI-7015 / 1b6661b.
We do need to "unbox" the null (ie, drop a stack from and load
a null) in general. The only time we can avoid this is if the
tree we are adapting is a
Constant(Literal(null)).I've added a test for both backends. Only GenICode exhibited
the problem.
Review by @gkossakowski, /cc @JamesIry