Skip to content

scala-js 0.6.23. fix warnings #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

scala-js 0.6.23. fix warnings #219

wants to merge 1 commit into from

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented May 18, 2018

No description provided.

@ashawley
Copy link
Member

What were the warnings? I'm working in a branch on updating scala-xml to 2.13.0-M4, and had updated to scala-js 0.6.23, but didn't see any warnings.

@xuwei-k
Copy link
Contributor Author

xuwei-k commented May 18, 2018 

build.sbt:18: warning: method crossProjectFromBuilder in trait CrossProjectExtra is deprecated: The built-in cross-project feature of sbt-scalajs is deprecated. Use the separate sbt plugin sbt-crossproject instead: https://github.com/portable-scala/sbt-crossproject
lazy val xml = crossProject.in(file("."))
               ^

https://github.com/scala-js/scala-js/blob/v0.6.23/sbt-plugin/src/main/scala/org/scalajs/sbtplugin/cross/CrossProject.scala#L370-L374

@xuwei-k
Copy link
Contributor Author

xuwei-k commented May 18, 2018

https://travis-ci.org/scala/scala-xml/jobs/380530645#L631-L633

@xuwei-k xuwei-k force-pushed the update-scala-js branch from 2da64ee to 5941167 Compare May 19, 2018 01:15
@ashawley
Copy link
Member

Fixed in #223.

@ashawley ashawley closed this May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethTisue SethTisue SethTisue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuwei-k @ashawley @SethTisue