This repository was archived by the owner on Sep 8, 2022. It is now read-only.
Build for Scala 2.11.7, 2.12.0-M1, 2.12.0-M2 and 2.12.0-M3 #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be tagged as release 1.0.11.
szeiger
force-pushed
the
wip/release-1.0.11
branch
from
f480422 to
10f9080
Compare
| else | ||
| sys.error(s"don't know what Scala versions to build on $java") | ||
| } | ||
|
|
||
| scalaXmlVersion := "1.0.4" | ||
| scalaXmlVersion := { | ||
| if(scalaVersion.value == "2.12.0-M3") "1.0.5" else "1.0.4" |
There was a problem hiding this comment.
won't this break as soon as we do M4? how about if(scalaVersion.value == "2.12.0-M2") "1.0.4" else "1.0.5"
There was a problem hiding this comment.
When we do M4 (and it's not binary compatible), we need to update scala-partest anyway (and scala-xml may well be an even newer version then), so I don't think it really makes a difference which way you write that check.
There was a problem hiding this comment.
Actually, the way it is at the moment is easier. We need 1.0.5 for 2.12.0-M3 and 1.0.4 for 2.12.0-M2, 2.12.0-M1 and 2.11.
|
Do not release / tag this yet. Another bugfix is coming. |
It used to be searched in ./build but that doesn’t work for the sbt build, where it is actually under ./build-sbt. The correct path is already on the partest classpath, so we can simply pull it from there with `findArtifact` instead of using `findJar`. Some other obsolete uses of `findJar` along with `buildPackLibDir` are also removed.
|
Added the bugfix. From my POV this is ready to be released so I can use it from the Scala build. |
|
LGTM |
adriaanm
added a commit
that referenced
this pull request
Dec 4, 2015
Build for Scala 2.11.7, 2.12.0-M1, 2.12.0-M2 and 2.12.0-M3
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Build for Scala 2.11.7, 2.12.0-M1, 2.12.0-M2 and 2.12.0-M3
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Build for Scala 2.11.7, 2.12.0-M1, 2.12.0-M2 and 2.12.0-M3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be tagged as release 1.0.11.