Skip to content
This repository was archived by the owner on Sep 8, 2022. It is now read-only.

Cleanups to new partest mode #100

Merged
merged 2 commits into from
Mar 8, 2018
Merged

Conversation

retronym
Copy link
Member

@retronym retronym commented Mar 8, 2018

  • fix (hopefully!) a race condition in system property save/restore
  • fix regression where --verbose output would end up in the test
    run log (where it would differ from the checkfile)

retronym added 2 commits March 8, 2018 12:23
Fixes the regression when running under `--verbose`

```
% scalac innerClassEnclMethodJavaReflection.scala
% <in process execution of jvm/innerClassEnclMethodJavaReflection.scala> > innerClassEnclMethodJavaReflection-jvm.log
% diff /Users/jz/code/scala/test/files/jvm/innerClassEnclMethodJavaReflection-jvm.log /Users/jz/code/scala/test/files/jvm/innerClassEnclMethodJavaReflection.check--- innerClassEnclMethodJavaReflection-jvm.log
+++ empty
@@ -1,3 +1,0 @@
-% scalac unreachable/Foo_1.scala
-% scalac t2470/Test_1.scala
-% scalac t2470/Read_Classfile_2.scala
```
@retronym retronym merged commit b44ccb0 into scala:1.1.x Mar 8, 2018
@retronym
Copy link
Member Author

retronym commented Mar 8, 2018

Related JDK bug report: https://bugs.openjdk.java.net/browse/JDK-6463019

lrytz pushed a commit to lrytz/scala-partest that referenced this pull request May 9, 2018
lrytz pushed a commit to lrytz/scala-partest that referenced this pull request May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant