fixing js version publishing #116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ilya-klyuchnikov, sorry for the delay: this was fixed directly for all modules in scala/sbt-scala-module#27 (#120) in the meantime, so I'll close this PR. Thanks for helping push this forward! A release with this fix will be out in a few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, scala-js version of scala-parser-combinators contains zero classes because no packages are exported for js-version. This fix ensures that OsgiKeys.exportPackage is set up for jvm and js versions.
Testing:
publishLocalbefore fix, check that jvm version is OK, but js version has zero classes.publishLocalafter fix, check that both versions are OK.