Skip to content

Unclosed multi-line comment not properly handled by StdLexical #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
martingd opened this issue Jun 10, 2021 · 1 comment
Closed

Unclosed multi-line comment not properly handled by StdLexical #399

martingd opened this issue Jun 10, 2021 · 1 comment

Comments

@martingd
Copy link
Contributor

In scala.util.parsing.combinator.lexical.StdLexical handling of unclosed multi-line comments (/* ... */) does not seem to work as expected.

If an unclosed multi-line comment is encountered, instead of returning one ErrorToken(unclosed comment), two ErrorToken(illegal character) tokens are returned (one for / and another for *) and scanning continues.

The issue is described in this comment.
#397 (comment)

@JakobLyngPetersen and I are working on a fix.
This was referenced Jun 10, 2021
Closed
Merged
@SethTisue
Copy link
Member

fixed by #403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SethTisue @martingd