Add support for Scala 2.12.0-M4 #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- M4 has native support for the `JFunction` types that used to be in this project but they are in `scala.runtime.java8`, not `scala.compat.java8`, so we move them to the same location. This breaks compatibility with the previous release of scala-java8-compat but now allows cross-building between Scala 2.11 and 2.12.0-M4. Tests and test support code is also moved to the new package. When building on 2.11 we still generate our own JFunctions but on 2.12 the native ones are used. - JFunctions in 2.12.0-M4 are not `Serializable` (see scala/scala-dev#129) so the test for that is disabled for the time being. - There is currently no genjavadoc-plugin for M4, so we only build the docs on 2.11.
szeiger
force-pushed
the
wip/scala-2.12.0-M4
branch
from
37a54b2 to
55df152
Compare
|
You can't publish without docs (sonatype won't let you close the repo), so we'll have to wait until we can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JFunctiontypes that used to be inthis project but they are in
scala.runtime.java8, notscala.compat.java8, so we move them to the same location. Thisbreaks compatibility with the previous release of scala-java8-compat
but now allows cross-building between Scala 2.11 and 2.12.0-M4.
Tests and test support code is also moved to the new package. When
building on 2.11 we still generate our own JFunctions but on 2.12
the native ones are used.
Serializable(seeUpdate JFunction code to latest version scala-dev#129) so the test for that
is disabled for the time being.
docs on 2.11.