Fix the DurationConverters import in README #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethTisue
reviewed
Mar 14, 2019
README.md
Outdated
|
|
||
| val javaDuration: java.time.Duration = 5.seconds.toJava | ||
| val finiteDuration: FiniteDuration = javaDuration.toScala | ||
| ``` | ||
|
|
||
| From Java: | ||
| ```java | ||
| import scala.compat.java8.DurationConverters; | ||
| import scala.compat.java8.DurationConverters._; |
There was a problem hiding this comment.
isn't the Java syntax something else? like * instead of _? and should it be import static perhaps?
There was a problem hiding this comment.
Ooops yes, it should be:
import static scala.compat.java8.DurationConverters.*;
There was a problem hiding this comment.
I have fixed and rebased.
There was a problem hiding this comment.
Actually, the java import was correct as is, I have reverted back, sorry.
SethTisue
reviewed
Mar 14, 2019
| @@ -268,15 +268,15 @@ Example of conversions from the Java type ways: | |||
|
|
|||
| ```scala | |||
| import scala.concurrent.duration._ | |||
| import scala.compat.java8.DurationConverters | |||
| import scala.compat.java8.DurationConverters._ | |||
filosganga
force-pushed
the
fix/fix-duration-typo
branch
from
1e2dc8f to
a8236f4
Compare
filosganga
force-pushed
the
fix/fix-duration-typo
branch
from
a8236f4 to
490473c
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Duration examples typo in README.