-
Notifications
You must be signed in to change notification settings - Fork 87
Update for Scala Native 0.4.0 #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Yeah, I pretty much knew it wouldn't pass but I can track your changes and try to figure out 2 test failures and then when Scala Native |
Just keeping this up to date. The test issues have been resolved in the above mentioned issue so now I can confirm that all the tests run in I could probably use some build expertise as the Note: Travis seems to run all the correct configurations. |
I'm afraid I don't know what the |
@SethTisue I figured it out it seems so now it is working fine if I tweak the build for I will follow up and rebase as needed until the release of Scala Native |
@ekrich the other PRs are merged now |
Will you want the commits squashed? I can push now but CI will fail until Scala Native is released |
squashing is better unless there's some reason to believe that having the individual commits in the history will assist future maintainers sometimes it's better to wait until the very end of the PR process to squash, if there's reason to believe that waiting may assist reviewers for this PR in particular, use your own judgment, but my hunch is you might as well just squash it |
I rebased but found more changes. I just pushed anyway. |
@SethTisue This should be ready for review, CI willing. The Scala Steward PRs can probably be closed. |
Trying to get a little jump on this. Works locally with two Scala Native tests failing on Scala
2.11-2.13
. Was able to testekrich/sconfig
against the locally built version and that worked fine.For CI
.travis.yml
update