Skip to content

Update for Scala Native 0.4.0 #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Update for Scala Native 0.4.0 #387

merged 3 commits into from
Jan 19, 2021

Conversation

ekrich
Copy link
Contributor

@ekrich ekrich commented Nov 20, 2020

Trying to get a little jump on this. Works locally with two Scala Native tests failing on Scala 2.11-2.13. Was able to test ekrich/sconfig against the locally built version and that worked fine.

For CI

  • Not sure if Scala Native SNAPSHOT will resolve
  • Not sure about the .travis.yml update

@SethTisue
Copy link
Member

[error] sbt.librarymanagement.ResolveException: Error downloading org.scala-native:sbt-scala-native;sbtVersion=1.0;scalaVersion=2.12:0.4.0-SNAPSHOT
[error]   Not found
[error]   Not found
[error]   not found: https://repo1.maven.org/maven2/org/scala-native/sbt-scala-native_2.12_1.0/0.4.0-SNAPSHOT/sbt-scala-native-0.4.0-SNAPSHOT.pom
[error]   not found: /home/travis/.ivy2/local/org.scala-native/sbt-scala-native/scala_2.12/sbt_1.0/0.4.0-SNAPSHOT/ivys/ivy.xml
[error]   not found: https://oss.sonatype.org/content/repositories/snapshots/org/scala-native/sbt-scala-native_2.12_1.0/0.4.0-SNAPSHOT/sbt-scala-native-0.4.0-SNAPSHOT.pom
[error]   not found: https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.scala-native/sbt-scala-native/scala_2.12/sbt_1.0/0.4.0-SNAPSHOT/ivys/ivy.xml
[error]   not found: https://repo.typesafe.com/typesafe/ivy-releases/org.scala-native/sbt-scala-native/scala_2.12/sbt_1.0/0.4.0-SNAPSHOT/ivys/ivy.xml

@ekrich
Copy link
Contributor Author

ekrich commented Nov 20, 2020

Yeah, I pretty much knew it wouldn't pass but I can track your changes and try to figure out 2 test failures and then when Scala Native 0.4.0 drops - ready.

@ekrich
Copy link
Contributor Author

ekrich commented Dec 2, 2020

Just keeping this up to date. The test issues have been resolved in the above mentioned issue so now I can confirm that all the tests run in 2.11-2.13 on Scala Native.

I could probably use some build expertise as the MultiScalaProject doesn't seem to support Scala Native like it does the other platforms. There is no .nativeSettings there and I can't seem to add it for the scalaVersion. The end result is that the build tries to apply Scala 3 to Scala Native when running test. Before the scalaVersion was fixed to 2.11 which worked ok. Any help appreciated.

Note: Travis seems to run all the correct configurations.

@SethTisue
Copy link
Member

I'm afraid I don't know what the MultiScalaProject problem might be — I suspect you'll need to seek help elsewhere with that

@ekrich
Copy link
Contributor Author

ekrich commented Dec 5, 2020

@SethTisue I figured it out it seems so now it is working fine if I tweak the build for 2.13.4 so the default SNAPSHOT for Scala Native matches.

I will follow up and rebase as needed until the release of Scala Native 0.4.0 and we should be able update with this PR.

@SethTisue
Copy link
Member

@ekrich the other PRs are merged now

@ekrich
Copy link
Contributor Author

ekrich commented Jan 12, 2021

Will you want the commits squashed? I can push now but CI will fail until Scala Native is released

@SethTisue
Copy link
Member

SethTisue commented Jan 12, 2021

squashing is better unless there's some reason to believe that having the individual commits in the history will assist future maintainers

sometimes it's better to wait until the very end of the PR process to squash, if there's reason to believe that waiting may assist reviewers

for this PR in particular, use your own judgment, but my hunch is you might as well just squash it

@ekrich
Copy link
Contributor Author

ekrich commented Jan 12, 2021

I rebased but found more changes. I just pushed anyway.

@ekrich
Copy link
Contributor Author

ekrich commented Jan 19, 2021

@SethTisue This should be ready for review, CI willing. The Scala Steward PRs can probably be closed.

@ekrich ekrich marked this pull request as ready for review January 19, 2021 15:57
@SethTisue SethTisue merged commit 5416c4a into scala:master Jan 19, 2021
@SethTisue SethTisue mentioned this pull request Jan 21, 2021
10 tasks
@ekrich ekrich deleted the topic/native040 branch March 13, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants