Skip to content

Russian Scala cheatsheet #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 4, 2019
Merged

Russian Scala cheatsheet #1255

merged 4 commits into from
Feb 4, 2019

Conversation

kotobotov
Copy link
Contributor

hi guys, i'd like to start translating some scala docs

@SethTisue
Copy link
Member

awesome! are there any Russian speakers watching this repo who could review this? (maybe you could ask on
https://t.me/scala_ru for a volunteer reviewer?)

Copy link
Contributor

@poslegm poslegm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you!

I noted a few grammatical issues. But I can miss something.

Copy link

@dos65 dos65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax and grammar are OK. There are just a few lines that could be improved.

@propensive
Copy link
Contributor

Can someone give me an update on how ready this is to merge, please? :)

Took 14 minutes
Took 13 minutes
@poslegm
Copy link
Contributor

poslegm commented Jan 29, 2019

@propensive Definitely this is not a perfect translation, but now the found errors have been corrected. In my humble opinion, you can merge it.

@kotobotov kotobotov changed the title ✨ Russian Scala cheatsheet Russian Scala cheatsheet Feb 1, 2019
@SethTisue SethTisue merged commit 48a3608 into scala:master Feb 4, 2019
@SethTisue
Copy link
Member

thank you @kotobotov and reviewers!

@kotobotov kotobotov deleted the ru_cheatsheets branch February 4, 2019 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants