Skip to content

reinstate spire, breeze, multibot #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2018

Conversation

SethTisue
Copy link
Member

fixes #672

@SethTisue
Copy link
Member Author

@SethTisue
Copy link
Member Author

SethTisue commented May 7, 2018

[breeze] [error] /Users/tisue/community.212/target-0.9.12/project-builds/breeze-c8fb167a2c9462bb82f2134a8a8fce5ebdd944f4/math/src/test/scala/breeze/stats/distributions/MultivariateGaussianTest.scala:34:21: value wrap is not a member of object org.scalacheck.Gen
[breeze] [error]  Note: implicit method arbDistr is not applicable here because it comes after the application point and it lacks an explicit result type
[breeze] [error]     Arbitrary { Gen.wrap(DenseVector.rand(N)) }
[breeze] [error]                     ^
[breeze] [error] /Users/tisue/community.212/target-0.9.12/project-builds/breeze-c8fb167a2c9462bb82f2134a8a8fce5ebdd944f4/math/src/test/scala/breeze/stats/distributions/MultivariateGaussianTest.scala:39:11: value wrap is not a member of object org.scalacheck.Gen
[breeze] [error]  Note: implicit method arbDistr is not applicable here because it comes after the application point and it lacks an explicit result type
[breeze] [error]       Gen.wrap {
[breeze] [error]           ^
[breeze] [error] two errors found
[breeze] [error] (math / Test / compileIncremental) Compilation failed

could be a ScalaCheck 1.13 vs 1.14 issue?

@dlwh would you like to try upgrading your repo to ScalaCheck 1.14.0?

@SethTisue
Copy link
Member Author

as for multibot,

[multibot] [info] - testScalaInterpreter *** FAILED ***
[multibot] [info]   "[java.lang.SecurityException: ("java.io.FilePermission" "/var/folders/j1/sv5gcszx0tn0t_q5xr58v1q40000gn/T/repl8930283871211067074.tmp/$line12" "write")
[multibot] [info]   	at org.multibot.ScriptSecurityManager$.doChecks(ScriptSecurityManager.scala:72)
[multibot] [info]   	at org.multibot.ScriptSecurityManager$.checkPermission(ScriptSecurityManager.scala:27)
[multibot] [info]   	at java.lang.SecurityManager.checkWrite(SecurityManager.java:979)
[multibot] [info]   	at sun.nio.fs.UnixPath.checkWrite(UnixPath.java:801)
[multibot] [info]   	at sun.nio.fs.UnixFileSystemProvider.createDirectory(UnixFileSystemProvider.java:376)

this is in a local run on MacOS. @OlegYch?

@SethTisue
Copy link
Member Author

with multibot tests only compiled not run, and with breeze tests not even compiled: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/2845/ (404 for now)

@SethTisue SethTisue merged commit 023e91c into scala:2.12.x May 7, 2018
@SethTisue SethTisue deleted the reinstate-spire-and-friends branch May 7, 2018 16:03
@SethTisue
Copy link
Member Author

merging because green in local testing, but let me know if y'all want to help with re-enabling the disabled pieces

@OlegYch
Copy link

OlegYch commented May 7, 2018

@SethTisue fixed multibot test, you can enable them

@SethTisue
Copy link
Member Author

@OlegYch thx! 1619f29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

re-add spire (and its dependencies breeze and multibot)
2 participants