add scalafix+scalameta+scalaparse+scalatex+ammonite-ops+geny+scalaj-http #472
Conversation
this rabbit hole was deep.
|
tested locally: |
| @@ -984,4 +989,60 @@ build += { | |||
| extra.exclude: ["plugin"] // we never build sbt plugins | |||
| } | |||
|
|
|||
| // forked to remove the usual bintray gunk | |||
There was a problem hiding this comment.
Can we provide some additional configuration on our side (e.g. -Dsbt.prohibit.publish=true) to make sure you don't need to maintain your fork?
There was a problem hiding this comment.
with this particular plugin, I don't think so, sadly. a bunch of other projects are affected, too. the ticket is lightbend-labs/dbuild#158
There was a problem hiding this comment.
(I actually did try -Dsbt.prohibit.publish=true before forking, to no avail.)
| "scalafix-nsc" // depends on circe which we don't have yet | ||
| // this didn't work; I decided to postpone any investigation. dbuild output an | ||
| // immensely long error (tens of megabytes), enough to choke Jenkins | ||
| "scalafix-tests" |
There was a problem hiding this comment.
Yes, I would exclude this directory. Here's where I run rewrites against a mini scalafix community-build. This involves cloning other projects and compiling them.
| uri: ${vars.uris.scalafix-uri} | ||
| extra.exclude: [ | ||
| "scalafix-sbt" // we never build sbt plugins | ||
| "scalafix-nsc" // depends on circe which we don't have yet |
There was a problem hiding this comment.
Note, most scalafix tests are currently in scalafix-nsc, core has a limited amount of tests. These tests depend on various projects (circe, shapeless,...) to reproduce bugs that surfaced in larger integration tests.
|
thanks Ólafur, I added your comments in 56c9c95 |
this rabbit hole was deep.