add conductr-lib

[SethTisue]

fyi @huntc

I can't actually test this quite yet because of another failure elsewhere in the build. I'll come back to it

[SethTisue]

ok, now we can test: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1068/consoleFull

[SethTisue]

oops, that was testing the wrong thing, try again: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1071/consoleFull (404 til Jenkins gets his woofers re-coned)

[SethTisue]

akka24ConductRClientLib needs akka-sse. new run: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1073/consoleFull (404 til Jenkins steals all the lemons from the neighbors' backyard)

[SethTisue]

@huntc at https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1074/consoleFull I'm seeing compile errors like:

[conductr-lib] [error] /Users/tisue/community.212/target-0.9.7-RC1/project-builds/conductr-lib-665de1fd0541e59f8aa87181f02f7642f7fe3a22/akka24-conductr-client-lib/src/main/scala/com/typesafe/conductr/clientlib/akka/BundlesConnector.scala:21: object pattern is not a member of package de.heikoseeberger.akkasse
[conductr-lib] [error] import de.heikoseeberger.akkasse.pattern.Streams
[conductr-lib] [error]                                  ^

I believe it's because you're using an old version of akka-sse.

in your build I see this comment:

// Cannot use the client lib with 2.12 until Play also moves there, and we use an akka-sse
// for 2.12.

what way forward here do you suggest? can you upgrade and use the latest akka-sse? or should we not even try to build akka24ConductRClientLib here, for now?

[huntc]

That particular lib shouldn't be processed. We are using sbt-doge to provide +compile.

[SethTisue]

ok, trying again without akka24ConductRClientLib : https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1075/consoleFull

(I don't follow what you're saying about sbt-doge, but maybe I don't need to?)

[huntc]

Thanks Seth. In essence only each sub project that has a cross build setting for 2.12 needs including. There are quite a few that are required to be excluded.

[SethTisue]

here's where we stand on what subprojects we are currently attempting to build:

[conductr-lib] [info] These subprojects will be built: root, play25ConductRBundleLib, play25ConductRClientLib, javaConductRBundleLib, javaTestLib, akka24ConductRBundleLib, scalaConductRClientLib, play25Common, scalaConductRBundleLib, akka24Common, scalaCommon, conductRBundleLib, javaCommon, common, akka24TestLib

do you see anything there you know right away I should throw out? (The community build has Akka 2.4 and Play 2.6, so maybe for starters I should throw out the play25 things? I think 2.6 hasn't diverged that much yet, so not sure...)

[SethTisue]

trying it without the Play ones (play25Common failed to compile in a local test): https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1076/consoleFull

[SethTisue]

sweet, sweet green!

[huntc]

Looks good. Thanks again Seth.

We cannot upgrade Akka-SSE right now (breaking changes). Thanks for working around all that.

[cunei]

@SethTisue Please check: lightbend-labs/dbuild@7ef6be7
Bintray-sbt based projects should be ok with 0.9.7-RC1. In theory, at least.

[SethTisue]

@cunei not in my experience — see lightbend-labs/dbuild#158, which I would suggest reopening as the problem doesn't seem to be solved. (I don't have the necessary access to reopen it myself.)