2.13: new Scala SHA #1579
Merged
2.13: new Scala SHA #1579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a series of "incompatible type in overriding" compilation errors, the first of which is regression? progression? or just a change downstream needs to adapt to? do I need to bisect? |
|
oh, it's obviously this StringBuilder PR: scala/scala#10047 @som-snytt offhand, I guess the PR is fine and we just need to change the code in scala-collection-contrib? wdyt? |
|
I'm going to merge this PR regardless — it's only one red repo, so let's book the overall progress |
It was a cliffhanger! |
SethTisue
added a commit
to SethTisue/scala-collection-contrib
that referenced
this pull request
Jul 20, 2022
namely scala/scala#10047 this came up at scala/community-build#1579 not for merge until 2.13.9 is actually released; in the meantime we can use the branch in the community build
|
The one-line change to scala-collection-contrib is scala/scala-collection-contrib#185 To make the repo green again here, I pushed 046e880 |
SethTisue
added a commit
to SethTisue/scala-collection-contrib
that referenced
this pull request
Oct 13, 2022
includes a small tweak necessary in order to adapt to scala/scala#10047 this originally came up at scala/community-build#1579
SethTisue
added a commit
to SethTisue/scala-collection-contrib
that referenced
this pull request
Oct 27, 2022
includes a small tweak necessary in order to adapt to scala/scala#10047 this originally came up at scala/community-build#1579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://scala-ci.typesafe.com/job/scala-2.13.x-jdk11-integrate-community-build/3816/
https://scala-ci.typesafe.com/job/scala-2.13.x-jdk11-integrate-community-build/3818/