Skip to content

2.12: new Scala SHA #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 29, 2021
Merged

Conversation

@SethTisue
Copy link
Member Author

SethTisue commented Jan 28, 2021

doobie failure

[doobie] [error] java.lang.UnsupportedOperationException: Position.point on NoPosition
[doobie] [error] 	at scala.reflect.internal.util.Position.fail(Position.scala:24)
[doobie] [error] 	at scala.reflect.internal.util.UndefinedPosition.point(Position.scala:102)
[doobie] [error] 	at scala.reflect.internal.util.UndefinedPosition.point(Position.scala:97)
[doobie] [error] 	at scala.reflect.internal.util.DeprecatedPosition.startOrPoint(Position.scala:260)
[doobie] [error] 	at scala.reflect.internal.util.DeprecatedPosition.startOrPoint$(Position.scala:260)
[doobie] [error] 	at scala.reflect.internal.util.Position.startOrPoint(Position.scala:19)
[doobie] [error] 	at org.wartremover.WartTraverser.hasTypeAscription(WartTraverser.scala:99)

spire failure

[spire] [error] ## Exception when compiling 156 sources to /home/jenkins/workspace/scala-2.12.x-jdk8-integrate-community-build/target-0.9.17/project-builds/spire-cf3a2817fe910988bd999352c09ade6244cfe229/core/.jvm/target/scala-2.12/classes
[spire] [error] scala.reflect.internal.Types$TypeError: type mismatch;
[spire] [error]  found   : Double
[spire] [error]  required: Object
[spire] [error] 
[spire] [error]            
[spire] [error] scala.reflect.internal.Types$TypeError: type mismatch;
[spire] [error]  found   : Double
[spire] [error]  required: Object
[spire] [error] (coreJVM / Compile / compileIncremental) scala.reflect.internal.Types$TypeError: type mismatch;
[spire] [error]  found   : Double
[spire] [error]  required: Object

@SethTisue
Copy link
Member Author

SethTisue commented Jan 28, 2021

the doobie thing is reproducible outside dbuild, in the community-build-2.12 branch in our fork of the repo under the scalacommunitybuild org, with ++2.12.14-bin-a9b6d67 and

-    addCompilerPlugin("org.typelevel" %% "kind-projector" % kindProjectorVersion cross CrossVersion.full),
+    addCompilerPlugin("org.typelevel" % "kind-projector_2.12.13" % kindProjectorVersion),

wartremover is involved, so isn't obvious whether this is scalac's fault or wartremover's fault

I do note that scala.reflect.internal.util.DeprecatedPosition is involved

oh, it looks like this may have been fixed, after our freeze point, by wartremover/wartremover#469 -- I'll try forking and cherry-picking that fix

UPDATE: yay, green in run 6445

@SethTisue
Copy link
Member Author

SethTisue commented Jan 28, 2021

as for spire, it's reproducible outside dbuild just with ++2.12.14-bin-a9b6d67 and coreJVM/compile

which makes it easy to bisect. roundup of the scala/scala suspects:

* 43a5a75bb1 - Merge pull request #9082 from retronym/ticket/scala-async-152 (3 days ago) <Lukas Rytz>
* 7ca86b97d5 - Merge pull request #9455 from retronym/ticket/sd-741-pipeline-main-race (3 days ago) <Lukas Rytz>
* f854b0f885 - Merge pull request #9356 from retronym/ticket/11882 (3 days ago) <Jason Zaugg>
* fdb88812ac - Merge pull request #9443 from som-snytt/issue/12315 (8 days ago) <Lukas Rytz>
* 2a693ec702 - Merge pull request #9355 from retronym/ticket/12213 (10 days ago) <Dale Wijnand>
* 2f1a80763d - Merge pull request #9436 from dwijnand/2.12/mima (13 days ago) <Dale Wijnand>
* e72a873f99 - Merge pull request #9315 from mkeskells/2.12.x_RedBlack_reuse_fp (13 days ago) <Dale Wijnand>
* 951c395c80 - Merge pull request #9316 from mkeskells/2.12.x_RedBlack_simple (2 weeks ago) <Seth Tisue>
* d613e1f5f9 - Merge pull request #9046 from mkeskells/2.12.x_RedBlackTree_remove_duplication (2 weeks ago) <Dale Wijnand>
* 78bf3a2d1e - Merge pull request #9342 from gzm0/annotated-literal-annotation-arg (2 weeks ago) <Dale Wijnand>
* 85a8814d26 - Merge pull request #9369 from sjrd/remove-dead-code-patmat-array-unit (2 weeks ago) <Dale Wijnand>
* d057f62275 - Merge pull request #9419 from koterpillar/patch-1 (2 weeks ago) <Dale Wijnand>
* f2d2e6e6e0 - Merge pull request #9426 from tanishiking/singleton-type-tree-12296 (2 weeks ago) <Seth Tisue>
* 8850b1fe0c - Merge pull request #9434 from aaabramov/patch-1 (2 weeks ago) <Seth Tisue>

bisecting shows the culprit PR to be scala/scala#9356 (2.12.14-bin-f854b0f)

I checked and the problem is also reproducible on spire master, not only the old version we're frozen on

I opened scala/scala-dev#760 on it

@SethTisue
Copy link
Member Author

SethTisue commented Jan 28, 2021

Jason pushed a fix for spire to scala/scala. I'll re-run with the new Scala SHA (once https://travis-ci.com/github/scala/scala/jobs/477767152 publishes it)

@SethTisue SethTisue marked this pull request as ready for review January 28, 2021 15:26
@SethTisue SethTisue merged commit 02a4a98 into scala:2.12.x Jan 29, 2021
@SethTisue SethTisue deleted the new-scala-2.12-sha-20210127 branch January 29, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant