Skip to content

dotty compat: no inner classes with name clashes #11360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adriaanm opened this issue Jun 15, 2016 · 4 comments
Closed

dotty compat: no inner classes with name clashes #11360

adriaanm opened this issue Jun 15, 2016 · 4 comments
Assignees
@adriaanm

Comments

@adriaanm
Copy link
Contributor

revive scala/scala#4832
@adriaanm adriaanm self-assigned this Jul 26, 2016
adriaanm referenced this issue in adriaanm/scala Jul 26, 2016
@adriaanm
Dotty compat: move Numeric#Ops to Numeric.Ops
ae41466 
Dotty does not allow name clashes of inner classes,
and the inner class is polluting Numeric's interface anyway.

Note that a similar case can be made for Ordering#Ops.

Also note that this breaks source compatibility.

Fixes scala/scala-dev#156
@SethTisue
Copy link
Member

#514 has a small amount of additional information and evidence that this is still a going concern

@SethTisue
Copy link
Member

SethTisue commented Nov 3, 2018 •
edited
Loading

this came up again at the SIP meeting today. the need to account for class shadowing led to a wart in TASTy (TERMREFin Length possiblySigned_NameRef qual_Type namespace_Type) we'd prefer to freeze off, so it sounds like we want to get the deprecation in for 2.13.0-RC1 so we can disallow this entirely in 2.14. /cc @adriaanm

@adriaanm adriaanm transferred this issue from scala/scala-dev Jan 16, 2019
@SethTisue SethTisue added this to the 2.13.0-RC1 milestone Jan 16, 2019
@adriaanm adriaanm modified the milestones: 2.13.0-RC1, 2.13.1 Feb 13, 2019
@szeiger szeiger modified the milestones: 2.13.1, 2.13.2 Aug 28, 2019
@SethTisue SethTisue modified the milestones: 2.13.2, 2.13.3 Feb 6, 2020
eed3si9n added a commit to eed3si9n/scala that referenced this issue Feb 8, 2020
@eed3si9n
Deprecate nested class shadowing
f21a26d 
Fixes scala/bug#8353
Fixes scala/bug#11360

This deprecates nested class shadowing for Dotty compatibilty.
@eed3si9n eed3si9n mentioned this issue Feb 8, 2020
Merged
@eed3si9n
Copy link
Member

eed3si9n commented Feb 8, 2020

Is this a duplicate of #8353?

eed3si9n added a commit to eed3si9n/scala that referenced this issue Feb 8, 2020
@eed3si9n
Deprecate nested class shadowing
0fd836c 
Fixes scala/bug#8353
Fixes scala/bug#11360

This deprecates nested class shadowing for Dotty compatibilty.
@adriaanm
Copy link
Contributor Author

adriaanm commented Feb 8, 2020

duplicate of #8353

@adriaanm adriaanm closed this as completed Feb 8, 2020
@SethTisue SethTisue removed this from the 2.13.3 milestone Feb 9, 2020
eed3si9n added a commit to eed3si9n/scala that referenced this issue Feb 9, 2020
@eed3si9n
Deprecate nested class shadowing
4d89123 
Fixes scala/bug#8353
Fixes scala/bug#11360

This deprecates nested class shadowing for Dotty compatibilty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adriaanm adriaanm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@szeiger @adriaanm @SethTisue @eed3si9n