Keyboard polyfill #61
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l15k4
force-pushed
the
keyboard-polyfill
branch
from
d0a899e to
d270403
Compare
l15k4
force-pushed
the
keyboard-polyfill
branch
from
d270403 to
5589495
Compare
|
I would use this - I am using this, but I just duplicated the file and am using it locally. |
|
I made it available as a library scalajs-keyboard-polyfil. Note it is not released or published yet until scalajs 6.0.0 is out. |
|
@sjrd we can close this one- scala-js-dom does not implement polyfills. |
|
Sure, oss library is more suitable here... |
Visbone
pushed a commit
to Visbone/scala-js-dom
that referenced
this pull request
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this conversation I'd like to discuss how to include this PR into scala-js-dom... It starts to be a little messy in there and we should think about a system that would allow for adding new extensions, polyfills and other cool things more easily... Meaning that it would be clear how and where to add it.
For instance here the
object KeyboardPolyfillis a polyfill thingy, theKCodeis a keyboard thingy andChCoderather Character thingy :-) Anyway all this stuff is quite essential if you want to do something really keyboard interactive...The polyfill's
normalizemethod will probablygrowas people will notice differences on different devices/browsers, which is mainly mobile devices and ios.