Skip to content

Remove unnecessary implicit conversions #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Remove unnecessary implicit conversions #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions api-reports/2_12.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24423,8 +24423,8 @@ experimental/PointerLock.PointerLockMouseEvent[JT] def movementY: Double
experimental/Vibration[SO] (@deprecated in 2.0.0)
experimental/beacon/package[SO] type BeaconNavigator = dom.Navigator (@deprecated in 2.0.0)
experimental/beacon/package[SO] type BeaconWorkerNavigator = dom.WorkerNavigator (@deprecated in 2.0.0)
experimental/beacon/package[SO] implicit def toBeaconNavigator(n: Navigator): BeaconNavigator (@deprecated in 2.0.0)
experimental/beacon/package[SO] implicit def toBeaconWorkerNavigator(n: WorkerNavigator): BeaconWorkerNavigator (@deprecated in 2.0.0)
experimental/beacon/package[SO] def toBeaconNavigator(n: Navigator): BeaconNavigator (@deprecated in 2.0.0)
experimental/beacon/package[SO] def toBeaconWorkerNavigator(n: WorkerNavigator): BeaconWorkerNavigator (@deprecated in 2.0.0)
experimental/cachestorage/package[SO] type Cache = dom.Cache (@deprecated in 2.0.0)
experimental/cachestorage/package[SO] type CacheQueryOptions = dom.CacheQueryOptions (@deprecated in 2.0.0)
experimental/cachestorage/package[SO] type CacheStorage = dom.CacheStorage (@deprecated in 2.0.0)
Expand Down Expand Up @@ -24494,7 +24494,7 @@ experimental/gamepad/package[SO] type GamepadEventInit = dom.GamepadEventInit (
experimental/gamepad/package[SO] type GamepadMappingType = dom.GamepadMappingType (@deprecated in 2.0.0)
experimental/gamepad/package[SO] type GamepadNavigator = dom.Navigator (@deprecated in 2.0.0)
experimental/gamepad/package[SO] def standard: dom.GamepadMappingType (@deprecated in 2.0.0)
experimental/gamepad/package[SO] implicit def toGamepad(navigator: dom.Navigator): GamepadNavigator (@deprecated in 2.0.0)
experimental/gamepad/package[SO] def toGamepad(navigator: dom.Navigator): GamepadNavigator (@deprecated in 2.0.0)
experimental/gamepad/package[SO] def unknown: dom.GamepadMappingType (@deprecated in 2.0.0)
experimental/intl/Collator[JC] def compare(string1: String, string2: String): Double
experimental/intl/Collator[JC] def resolvedOptions(): CollatorOptions
Expand Down
6 changes: 3 additions & 3 deletions api-reports/2_13.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24423,8 +24423,8 @@ experimental/PointerLock.PointerLockMouseEvent[JT] def movementY: Double
experimental/Vibration[SO] (@deprecated in 2.0.0)
experimental/beacon/package[SO] type BeaconNavigator = dom.Navigator (@deprecated in 2.0.0)
experimental/beacon/package[SO] type BeaconWorkerNavigator = dom.WorkerNavigator (@deprecated in 2.0.0)
experimental/beacon/package[SO] implicit def toBeaconNavigator(n: Navigator): BeaconNavigator (@deprecated in 2.0.0)
experimental/beacon/package[SO] implicit def toBeaconWorkerNavigator(n: WorkerNavigator): BeaconWorkerNavigator (@deprecated in 2.0.0)
experimental/beacon/package[SO] def toBeaconNavigator(n: Navigator): BeaconNavigator (@deprecated in 2.0.0)
experimental/beacon/package[SO] def toBeaconWorkerNavigator(n: WorkerNavigator): BeaconWorkerNavigator (@deprecated in 2.0.0)
experimental/cachestorage/package[SO] type Cache = dom.Cache (@deprecated in 2.0.0)
experimental/cachestorage/package[SO] type CacheQueryOptions = dom.CacheQueryOptions (@deprecated in 2.0.0)
experimental/cachestorage/package[SO] type CacheStorage = dom.CacheStorage (@deprecated in 2.0.0)
Expand Down Expand Up @@ -24494,7 +24494,7 @@ experimental/gamepad/package[SO] type GamepadEventInit = dom.GamepadEventInit (
experimental/gamepad/package[SO] type GamepadMappingType = dom.GamepadMappingType (@deprecated in 2.0.0)
experimental/gamepad/package[SO] type GamepadNavigator = dom.Navigator (@deprecated in 2.0.0)
experimental/gamepad/package[SO] def standard: dom.GamepadMappingType (@deprecated in 2.0.0)
experimental/gamepad/package[SO] implicit def toGamepad(navigator: dom.Navigator): GamepadNavigator (@deprecated in 2.0.0)
experimental/gamepad/package[SO] def toGamepad(navigator: dom.Navigator): GamepadNavigator (@deprecated in 2.0.0)
experimental/gamepad/package[SO] def unknown: dom.GamepadMappingType (@deprecated in 2.0.0)
experimental/intl/Collator[JC] def compare(string1: String, string2: String): Double
experimental/intl/Collator[JC] def resolvedOptions(): CollatorOptions
Expand Down
6 changes: 2 additions & 4 deletions src/main/scala/org/scalajs/dom/experimental/beacon/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ package org.scalajs
package dom
package experimental

import scala.language.implicitConversions

package object beacon {

@deprecated("use dom.Navigator instead", "2.0.0")
Expand All @@ -13,11 +11,11 @@ package object beacon {
type BeaconWorkerNavigator = dom.WorkerNavigator

@deprecated("use dom.Navigator directly instead", "2.0.0")
implicit def toBeaconNavigator(n: Navigator): BeaconNavigator =
def toBeaconNavigator(n: Navigator): BeaconNavigator =
n

@deprecated("use dom.WorkerNavigator directly instead", "2.0.0")
implicit def toBeaconWorkerNavigator(n: WorkerNavigator): BeaconWorkerNavigator =
def toBeaconWorkerNavigator(n: WorkerNavigator): BeaconWorkerNavigator =
n

}
4 changes: 1 addition & 3 deletions src/main/scala/org/scalajs/dom/experimental/gamepad/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package org.scalajs
package dom.experimental

import scala.language.implicitConversions

package object gamepad {

@deprecated("use dom.GamepadMappingType instead", "2.0.0")
Expand All @@ -24,7 +22,7 @@ package object gamepad {
type GamepadNavigator = dom.Navigator

@deprecated("use dom.Navigator directly instead", "2.0.0")
implicit def toGamepad(navigator: dom.Navigator): GamepadNavigator =
def toGamepad(navigator: dom.Navigator): GamepadNavigator =
navigator

@deprecated("use dom.GamepadMappingType.`unknown` instead", "2.0.0")
Expand Down