Add charCode method binding to KeyboardEvent #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we make that a |
|
From my experience it's in all browsers. Possibly with 0 value in case of keyup/keydown... Imho all browsers have it present and pass it 0 in cases it doesn't represent a unicode value. |
|
LGTM OK. |
sjrd
added a commit
that referenced
this pull request
Oct 8, 2014
Add charCode method binding to KeyboardEvent
Visbone
pushed a commit
to Visbone/scala-js-dom
that referenced
this pull request
Mar 18, 2021
Update sbt-dotty to 0.5.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thing is, that even though keypress event is to be deprecated in favor of beforeinput, it's still in far future.
Currently there is no way to get hold of keypress event unicode value in Gecko based browsers where you can find it with certainty in charCode only. (based on my todays investigations).
For further reading, please see this google groups thread