Skip to content

Sort API members by name #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Sort API members by name #483

wants to merge 1 commit into from

Conversation

armanbilge
Copy link
Member

@japgolly is this what you are looking for?

@armanbilge armanbilge marked this pull request as draft August 13, 2021 01:34
@japgolly
Copy link
Contributor

Close! Types still need to come first though. Sorting key should be (prefix, name, body)

@armanbilge armanbilge mentioned this pull request Aug 13, 2021
Closed
@japgolly
Copy link
Contributor

Wait, no no no. Yeah I didn't think it would be this easy. name here is the scope name, not the member name. The member name is currently lost from MutableState's pov. You'd have to change the .add methods in MutableState.Scope to also accept name and then plumb it through

@armanbilge
Copy link
Member Author

Hmm ok maybe this is more one for you 😅

@japgolly
Copy link
Contributor

hehe np

@japgolly
Copy link
Contributor

Superseded by #484

@japgolly japgolly closed this Aug 13, 2021
@armanbilge armanbilge deleted the issue/482 branch August 13, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armanbilge @japgolly