Skip to content

Minor improvements #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 10, 2021
Merged

Minor improvements #464

merged 4 commits into from
Aug 10, 2021

Conversation

japgolly
Copy link
Contributor

No description provided.

@japgolly japgolly requested a review from armanbilge August 10, 2021 02:01
Comment on lines +10 to +12
metals.sbt
target/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!! lol

@japgolly japgolly merged commit cf3c530 into series/1.x Aug 10, 2021
@japgolly japgolly deleted the topic/minorFixes-1x branch August 10, 2021 02:04
<id>armanbilge</id>
<name>Arman Bilge</name>
<url>https://github.com/armanbilge</url>
</developer>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wtf? Sorry about the order @armanbilge . No one cares but it's still weird and unintentional

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol yeah I'm surprised I made 3rd ;) no worries, cool to have my name among the giants!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah man, it's cos I copy-pasted the top one (lihaoyi) twice and then modified but it seems I ended up modifying instance 2 instead of 3. Sorry lol. Doesn't matter anway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants