Skip to content

IDBVersionChangeEvent.newVersion can be null #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2021
Merged

IDBVersionChangeEvent.newVersion can be null #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef6993e
IDBVersionChangeEvent.newVersion can be null
japgolly Nov 14, 2020
53e9b00
Merge branch 'series/1.x' into bug/idbNewVer
japgolly Aug 20, 2021
3182de1
Run `sbt prePR`
japgolly Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api-reports/2_12.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15219,7 +15219,7 @@ raw/IDBVersionChangeEvent[JC] def currentTarget: EventTarget
raw/IDBVersionChangeEvent[JC] def defaultPrevented: Boolean
raw/IDBVersionChangeEvent[JC] def eventPhase: Int
raw/IDBVersionChangeEvent[JC] def isTrusted: Boolean
raw/IDBVersionChangeEvent[JC] def newVersion: Int
raw/IDBVersionChangeEvent[JC] def newVersion: Integer
raw/IDBVersionChangeEvent[JC] def oldVersion: Int
raw/IDBVersionChangeEvent[JC] def preventDefault(): Unit
raw/IDBVersionChangeEvent[JC] def stopImmediatePropagation(): Unit
Expand All @@ -15230,7 +15230,7 @@ raw/IDBVersionChangeEvent[JC] def `type`: String
raw/IDBVersionChangeEventInit[JT] var bubbles: js.UndefOr[Boolean]
raw/IDBVersionChangeEventInit[JT] var cancelable: js.UndefOr[Boolean]
raw/IDBVersionChangeEventInit[JT] var composed: js.UndefOr[Boolean]
raw/IDBVersionChangeEventInit[JT] var newVersion: js.UndefOr[Int]
raw/IDBVersionChangeEventInit[JT] var newVersion: js.UndefOr[Integer]
raw/IDBVersionChangeEventInit[JT] var oldVersion: js.UndefOr[Int]
raw/IDBVersionChangeEventInit[JT] var scoped: js.UndefOr[Boolean]
raw/ImageData[JC] def data: js.Array[Int]
Expand Down
4 changes: 2 additions & 2 deletions api-reports/2_13.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15219,7 +15219,7 @@ raw/IDBVersionChangeEvent[JC] def currentTarget: EventTarget
raw/IDBVersionChangeEvent[JC] def defaultPrevented: Boolean
raw/IDBVersionChangeEvent[JC] def eventPhase: Int
raw/IDBVersionChangeEvent[JC] def isTrusted: Boolean
raw/IDBVersionChangeEvent[JC] def newVersion: Int
raw/IDBVersionChangeEvent[JC] def newVersion: Integer
raw/IDBVersionChangeEvent[JC] def oldVersion: Int
raw/IDBVersionChangeEvent[JC] def preventDefault(): Unit
raw/IDBVersionChangeEvent[JC] def stopImmediatePropagation(): Unit
Expand All @@ -15230,7 +15230,7 @@ raw/IDBVersionChangeEvent[JC] def `type`: String
raw/IDBVersionChangeEventInit[JT] var bubbles: js.UndefOr[Boolean]
raw/IDBVersionChangeEventInit[JT] var cancelable: js.UndefOr[Boolean]
raw/IDBVersionChangeEventInit[JT] var composed: js.UndefOr[Boolean]
raw/IDBVersionChangeEventInit[JT] var newVersion: js.UndefOr[Int]
raw/IDBVersionChangeEventInit[JT] var newVersion: js.UndefOr[Integer]
raw/IDBVersionChangeEventInit[JT] var oldVersion: js.UndefOr[Int]
raw/IDBVersionChangeEventInit[JT] var scoped: js.UndefOr[Boolean]
raw/ImageData[JC] def data: js.Array[Int]
Expand Down
6 changes: 4 additions & 2 deletions src/main/scala/org/scalajs/dom/raw/Idb.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ class IDBObjectStore extends js.Object {
}

trait IDBVersionChangeEventInit extends EventInit {
var newVersion: js.UndefOr[Int] = js.undefined
var newVersion: js.UndefOr[Integer] = js.undefined
var oldVersion: js.UndefOr[Int] = js.undefined
}

Expand All @@ -142,9 +142,11 @@ class IDBVersionChangeEvent(typeArg: String,
/**
* Returns the new version of the database.
*
* This is null when the database is being deleted.
*
* MDN
*/
def newVersion: Int = js.native
def newVersion: Integer = js.native

/**
* Returns the old version of the database.
Expand Down