Fix #346: Give the correct type to PushSubscription.toJSON #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix proposal for #346 |
sjrd
requested changes
Feb 21, 2019
| * | ||
| * MDN | ||
| */ | ||
| val expirationTime: Double = js.native |
There was a problem hiding this comment.
This should be a java.lang.Double so that null is an acceptable value.
| @@ -98,7 +115,7 @@ trait PushSubscription extends js.Object { | |||
| * | |||
| * MDN | |||
| */ | |||
| def toJSON(): String = js.native | |||
| def toJSON(): js.Dictionary[js.Any] = js.native | |||
There was a problem hiding this comment.
You should use a new type PushSubscriptionJSON as specified at https://www.w3.org/TR/2018/WD-push-api-20181026/#pushsubscription-interface. Something like:
trait PushSubscriptionJSON extends js.Object {
val endpoint: String
val expirationTime: java.lang.Double
val keys: js.Dictionary[String]
}
Update PushSubscription to better reflect w3 standards: -Change the return type of method toJSON -Add missing properties (expirationTime, options)
FabioPinheiro
force-pushed
the
master
branch
2 times, most recently
from
b3cd82b to
b488d71
Compare
sjrd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update PushSubscription to better reflect w3 standards:
-Change the return type of method toJSON
-Add missing properties (expirationTime, options)
Disclosure I have no idea what I'm doing here or if this is event a problem for anyone else.
(The impression that I have is that if any one is calling this method this will throw a cast extension)
This PR fix my problem but I don't know if this
js.Dictionary[js.Any]is the right type, and maybe could be better refine. (https://www.w3.org/TR/2018/WD-push-api-20181026/#idl-def-pushsubscriptionoptionsinit)