Add Element.matches which has all modern browser support #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
requested changes
Feb 14, 2019
| /** | ||
| * Supported by FF>34, Opera>21, Chrome>34, IE>9, Safari>4 | ||
| * | ||
| * @see https://developer.mozilla.org/en-US/docs/Web/API/Element/matches |
There was a problem hiding this comment.
I see that some comments above have this form, but they are the exception, not the norm. The appropriate Scaladoc is to copy-paste the description at the top of the MDN page, and add MDN at the end:
/**
* The `matches()` method of the `Element` interface returns `true` if the
* element would be selected by the specified selector string; otherwise, it
* returns `false`.
*
* MDN
*/
Indeed, we don't do polyfills. |
er1c
force-pushed
the
element-matches
branch
from
2955860 to
b66ca65
Compare
sjrd
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternatively, this could be implemented as a polyfill for older browser support, but I don't think scala-js does anything with a polyfill, correct?