Add types for AbortController #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add AbortController and AbortSignal classes along with adding `signal` to the Fetch request classes. In addition also add `keepalive` to Fetch request and fix the names of the `cache` and `redirect` properties.
|
Can we get this merged? I'd like to abort some fetch requests and have that in this library vs my own code. |
sjrd
requested changes
Feb 21, 2019
src/main/scala/org/scalajs/dom/experimental/AbortController.scala
Outdated
Show resolved
Hide resolved
|
I'm reading https://fetch.spec.whatwg.org/#body and don't see where keepalive can change. How did you interpret it that way? I'm all for deprecating the binary API of apply. |
|
Hum indeed it seems |
sjrd
requested changes
Feb 22, 2019
Change types for properties that can change from `val` to `def`.
sjrd
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AbortController and AbortSignal classes along with adding
signalto the Fetch request classes. In addition also add
keepaliveto Fetchrequest and fix the names of the
cacheandredirectproperties.