Return HTMLCollection in getElementsBy*()

[tindzk]

At the moment, all getElementsBy* functions return a NodeList, but the items are guaranteed to be Elements. Therefore, to access an item as an Element, a cast is required.

Furthermore, I would propose to remove the function getElementsByName() which does not appear in the DOM interfaces and seems to have been superseded by getElementsByTagName(). If you agree, I will add a separate commit for it to this pull request.

See also:

• https://dom.spec.whatwg.org/#document
• https://dom.spec.whatwg.org/#element

[sjrd]

Isn't there something about SVG DOM things that precisely aren't Elements but Nodes? Or am I confused about something else?

[sjrd]

Why was this moved from its previous location? It creates a bigger diff than necessary.

[tindzk]

I moved it for more consistency with Document and the DOM specification, which both declare getElementsByTagName first and getElementsByTagNameNS afterwards. When I originally saw the file, I was under the impression that getElementsByTagName was missing and added it. This confusion could have been avoided if it was placed before getElementsByTagNameNS.

[tindzk]

If you have svg nodes in mind, getElementsByTagName("svg") would return a node list of Elements (which is exactly what an HTMLCollection is). The Typescript's bindings are actually more expressive and return NodeListOf<SVGSVGElement>. In Scala 2.13, we could implement it the same way with literal types.

[sjrd]

OK thanks for the clarifications.