Skip to content

Remove attributes class members from Node #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andriygm opened this issue Apr 12, 2023 · 0 comments · Fixed by #775
Closed

Remove attributes class members from Node #772

andriygm opened this issue Apr 12, 2023 · 0 comments · Fixed by #775
Labels
bug

Comments

@andriygm
Copy link

andriygm commented Apr 12, 2023 •
edited
Loading

Currently, the Node class contains members not present in JavaScript's Node class. Namely,

def attributes: NamedNodeMap = js.native
def hasAttributes(): Boolean = js.native

These should be removed.
@armanbilge armanbilge added the bug label Apr 12, 2023
@zetashift zetashift mentioned this issue May 6, 2023
Merged
armanbilge added a commit that referenced this issue May 11, 2023
@armanbilge
Merge pull request #775 from zetashift/fix/#772
9219568 
Remove attributes members from Node class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove attributes members from Node class zetashift/scala-js-dom
2 participants
@armanbilge @andriygm