Skip to content

Location#origin should return a String #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
armanbilge opened this issue Nov 12, 2022 · 1 comment · Fixed by #761
Closed

Location#origin should return a String #746

armanbilge opened this issue Nov 12, 2022 · 1 comment · Fixed by #761
Labels

Comments

@armanbilge
Copy link
Member

There's a reason it doesn't, but it's not a particularly good one.

* This property also does not exist consistently on IE, even as new as IE11, hence it must be UndefOr.
*/
def origin: js.UndefOr[String] = js.native

https://developer.mozilla.org/en-US/docs/Web/API/Location/origin#browser_compatibility

@armanbilge
Copy link
Member Author

Oh and also this flag parameter is not part of the spec, just a firefox thing ...

def reload(flag: Boolean = js.native): Unit = js.native

zetashift added a commit to zetashift/scala-js-dom that referenced this issue Jan 27, 2023
armanbilge added a commit that referenced this issue Jan 28, 2023
Fixup Location#origin and Location#reload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant