Skip to content
This repository was archived by the owner on Sep 3, 2020. It is now read-only.

Commit 89ea359

Browse files
authored
Merge pull request #201 from retronym/topic/tolerant-fresh-names
Make tests tolerant to differing fresh name suffixes
2 parents f82bf38 + f5b91d8 commit 89ea359

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

src/test/scala/scala/tools/refactoring/tests/implementations/extraction/ExtractExtractorTest.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ class ExtractExtractorTest extends TestHelper with TestRefactoring {
266266
}
267267
}
268268
"""
269-
}.performRefactoring(extract(0)).assertEqualTree
269+
}.performRefactoring(extract(0)).assertEqualTreeIgnoringFreshNames
270270

271271
@Test
272272
def avoidNameCollisions() = new FileSet{

src/test/scala/scala/tools/refactoring/tests/implementations/extraction/ExtractValueTest.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ class ExtractValueTest extends TestHelper with TestRefactoring {
343343
}
344344
}
345345
"""
346-
}.performRefactoring(extract(0)).assertEqualTree
346+
}.performRefactoring(extract(0)).assertEqualTreeIgnoringFreshNames
347347

348348
@Test
349349
def dontExtractWildcardPatterns() = new FileSet(expectCompilingCode = false) {
@@ -364,7 +364,7 @@ class ExtractValueTest extends TestHelper with TestRefactoring {
364364
}
365365
}
366366
"""
367-
}.performRefactoring(extract(0)).assertEqualTree
367+
}.performRefactoring(extract(0)).assertEqualTreeIgnoringFreshNames
368368

369369
@Test
370370
def extractIntoNewValBlock() = new FileSet{

src/test/scala/scala/tools/refactoring/tests/util/TestHelper.scala

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,14 @@ trait TestHelper extends TestRules with Refactoring with CompilerProvider with c
281281
}
282282
assertEquals(expected, actual)
283283
}
284+
def assertEqualTreeIgnoringFreshNames() = withResultTree { actualTree =>
285+
val expectedTree = treeFrom(srcs.head._2.code)
286+
def clean(s: String) = s.replaceAll("""\$\d+""", """\$""")
287+
val (expected, actual) = global.ask { () =>
288+
(clean(expectedTree.toString()), clean(actualTree.toString()))
289+
}
290+
assertEquals(expected, actual)
291+
}
284292
}
285293
}
286294

0 commit comments

Comments
 (0)