Skip to content

Commit 5815b68

Browse files
committed
Assert if MODULARIZE factory function is used with new.
Once we start using `async` for for this function then `new` stops working: emscripten-core#23157. Using `new` in this was was always an antipattern but there was nothing stopping users from doing this.
1 parent c4ecb13 commit 5815b68

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ See docs/process.md for more on how version tagging works.
3636
This paves the way for marking the function as `async` which does not allow
3737
`new` to be used. This usage of `new` here was never documented and is
3838
considered and antipattern. (#23210)
39+
considered an antipattern. (#23210)
3940
- `PATH.basename()` no longer calls `PATH.normalize()`, so that
4041
`PATH.basename("a/.")` returns `"."` instead of `"a"` and
4142
`PATH.basename("a/b/..")` returns `".."` instead of `"a"`. This is in line with

0 commit comments

Comments
 (0)